public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

* linux-next build failure on m68k in nfs code
@ 2014-05-29 19:40 Paul Gortmaker
  2014-05-29 20:32 ` Trond Myklebust
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2014-05-29 19:40 UTC (permalink / raw)
  To: Trond Myklebust; +Cc: dros, linux-next@vger•kernel.org, Geert Uytterhoeven

Hi Trond,

I'm seeing this on today's linux-next with m68k allmodconfig:

ERROR: "__umoddi3" [fs/nfs/nfs_layout_nfsv41_files.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Making this obviously incorrect change makes it go away:


        /* calculate remaining bytes in the current stripe */
-       stripe_offset = ((u64)req_offset(req) - segment_offset) % stripe_unit;
+       stripe_offset = 0; // ((u64)req_offset(req) - segment_offset) % stripe_unit;


The line above comes from:

commit fa1165eda0eeaee57c292df3af1c98e10223f0f5
Author: Weston Andros Adamson <dros@primarydata•com>
Date:   Thu May 15 11:56:56 2014 -0400

    pnfs: filelayout: support non page aligned layouts

Looks like it needs to use the proper 64bit math wrappers.

Thanks,
Paul.

^ permalink raw reply	[flat|nested] 2+ messages in thread

• * Re: linux-next build failure on m68k in nfs code
    2014-05-29 19:40 linux-next build failure on m68k in nfs code Paul Gortmaker
  @ 2014-05-29 20:32 ` Trond Myklebust
    0 siblings, 0 replies; 2+ messages in thread
  From: Trond Myklebust @ 2014-05-29 20:32 UTC (permalink / raw)
    To: Paul Gortmaker
    Cc: Weston Andros Adamson, linux-next@vger•kernel.org,
  	Geert Uytterhoeven
  
  Hi Paul
  
  On Thu, May 29, 2014 at 3:40 PM, Paul Gortmaker
  <paul.gortmaker@windriver•com> wrote:
  > Hi Trond,
  >
  > I'm seeing this on today's linux-next with m68k allmodconfig:
  >
  > ERROR: "__umoddi3" [fs/nfs/nfs_layout_nfsv41_files.ko] undefined!
  > make[1]: *** [__modpost] Error 1
  > make: *** [modules] Error 2
  >
  > Making this obviously incorrect change makes it go away:
  >
  >
  >         /* calculate remaining bytes in the current stripe */
  > -       stripe_offset = ((u64)req_offset(req) - segment_offset) % stripe_unit;
  > +       stripe_offset = 0; // ((u64)req_offset(req) - segment_offset) % stripe_unit;
  >
  >
  > The line above comes from:
  >
  > commit fa1165eda0eeaee57c292df3af1c98e10223f0f5
  > Author: Weston Andros Adamson <dros@primarydata•com>
  > Date:   Thu May 15 11:56:56 2014 -0400
  >
  >     pnfs: filelayout: support non page aligned layouts
  >
  > Looks like it needs to use the proper 64bit math wrappers.
  
  Yes. I already fixed up patch this morning in my linux-next branch, so
  I'm hoping it will be OK the next time you pull from Stephen's tree.
  
  For the record, the correct fix should be to replace the above line with
  
  div_u64_rem((u64)req_offset(req) - segment_offset, stripe_unit, &stripe_offset);
  
  Thanks
    Trond
  
  -- 
  Trond Myklebust
  
  Linux NFS client maintainer, PrimaryData
  
  trond.myklebust@primarydata•com
  
  ^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-29 20:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-29 19:40 linux-next build failure on m68k in nfs code Paul Gortmaker
2014-05-29 20:32 ` Trond Myklebust

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox