public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead•org>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
	Linux Next Mailing List <linux-next@vger•kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
	Platform Driver <platform-driver-x86@vger•kernel.org>,
	Lennert Buytenhek <buytenh@wantstofly•org>,
	Lubomir Rintel <lkundrak@v3•sk>,
	Darren Hart <dvhart@infradead•org>,
	Andy Shevchenko <andy@infradead•org>
Subject: Re: linux-next: Tree for May 28 (platform/olpc/olpc-xo175-ec)
Date: Tue, 28 May 2019 11:05:09 -0700	[thread overview]
Message-ID: <68b2b71a-970b-8e0e-1ee3-e05a51c3bdf2@infradead.org> (raw)
In-Reply-To: <20190528145838.23b73e25@canb.auug.org.au>

On 5/27/19 9:58 PM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20190524:
> 

on x86, there are some issues with drivers/platform/olpc/olpc-xo175-ec.c:

a. when CONFIG_SPI is not set/enabled:

WARNING: unmet direct dependencies detected for SPI_SLAVE
  Depends on [n]: SPI [=n]
  Selected by [y]:
  - OLPC_XO175_EC [=y] && (ARCH_MMP || COMPILE_TEST [=y])

ld: drivers/platform/olpc/olpc-xo175-ec.o: in function `olpc_xo175_ec_remove':
olpc-xo175-ec.c:(.text+0x79): undefined reference to `spi_slave_abort'
ld: drivers/platform/olpc/olpc-xo175-ec.o: in function `olpc_xo175_ec_send_command':
olpc-xo175-ec.c:(.text+0x24d): undefined reference to `spi_async'
ld: drivers/platform/olpc/olpc-xo175-ec.o: in function `olpc_xo175_ec_cmd':
olpc-xo175-ec.c:(.text+0xb3c): undefined reference to `spi_slave_abort'
ld: drivers/platform/olpc/olpc-xo175-ec.o: in function `olpc_xo175_ec_spi_driver_init':
olpc-xo175-ec.c:(.init.text+0xa): undefined reference to `__spi_register_driver'

b. when CONFIG_INPUT is not set/enabled:

ERROR: "input_register_device" [drivers/platform/olpc/olpc-xo175-ec.ko] undefined!
ERROR: "input_set_capability" [drivers/platform/olpc/olpc-xo175-ec.ko] undefined!
ERROR: "devm_input_allocate_device" [drivers/platform/olpc/olpc-xo175-ec.ko] undefined!
ERROR: "input_event" [drivers/platform/olpc/olpc-xo175-ec.ko] undefined!

c. when some power mgt. Kconfig symbol is not set/enabled:

ERROR: "power_supply_put" [drivers/platform/olpc/olpc-xo175-ec.ko] undefined!
ERROR: "power_supply_changed" [drivers/platform/olpc/olpc-xo175-ec.ko] undefined!
ERROR: "power_supply_get_by_name" [drivers/platform/olpc/olpc-xo175-ec.ko] undefined!

d. drivers/platform/olpc/Kconfig needs to use "menuconfig" like all of the other
   Kconfig files in drivers/platform/ so that its menu is listed in the correct
   place in *config interfaces.


:(

-- 
~Randy

  reply	other threads:[~2019-05-28 18:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28  4:58 linux-next: Tree for May 28 Stephen Rothwell
2019-05-28 18:05 ` Randy Dunlap [this message]
2019-05-29  6:27   ` linux-next: Tree for May 28 (platform/olpc/olpc-xo175-ec) Lubomir Rintel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68b2b71a-970b-8e0e-1ee3-e05a51c3bdf2@infradead.org \
    --to=rdunlap@infradead$(echo .)org \
    --cc=andy@infradead$(echo .)org \
    --cc=buytenh@wantstofly$(echo .)org \
    --cc=dvhart@infradead$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=lkundrak@v3$(echo .)sk \
    --cc=platform-driver-x86@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox