From: Haojian Zhuang <haojian.zhuang@gmail•com>
To: sfr@canb•auug.org.au
Cc: Samuel Ortiz <sameo@openedhand•com>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
Mark Brown <broonie@opensource•wolfsonmicro.com>
Subject: Re: linux-next: mfd tree build failure
Date: Thu, 8 Oct 2009 01:59:12 -0400 [thread overview]
Message-ID: <771cded00910072259m5aeaf900w376deb99b7f2b081@mail.gmail.com> (raw)
In-Reply-To: <25B60CDC2F704E4E9D88FFD52780CB4C04B6A37960@SC-VEXCH1.marvell.com>
> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb•auug.org.au]
> Sent: 2009年10月6日 11:54 AM
> To: Haojian Zhuang
> Cc: Samuel Ortiz; linux-next@vger•kernel.org; linux-kernel@vger•kernel.org; Mark Brown
> Subject: Re: linux-next: mfd tree build failure
>
> Hi Haojian,
>
> On Mon, 5 Oct 2009 19:35:05 -0700 Haojian Zhuang <hzhuang1@marvell•com> wrote:
>>
>> Could you send your .config file to me? The 88pm8607 patch is just for mfd-2.6 git tree. I didn't try it in linux-next git tree before. I can try it now. If I could have your .config file, it would be better.
>
> I am sorry, but I don't have the exact .config file any more (I have
> moved on in my creation of linux-next) however, as I said, this was an
> allmodconfig build on x86_64. I also noted that CONFIG_I2C=m and
> CONFIG_MFD_CORE=m, while the config entry that controls the building of
> this driver is a bool so must have been 'y'. So from a builtin driver,
> you are referring to symbols that are only defined in modules.
>
> --
> Cheers,
> Stephen Rothwell sfr@canb•auug.org.au
> http://www.canb.auug.org.au/~sfr/
>
Hi Stephen & Samuel,
Please ignore the original fix patch on 88pm8607 dependancy. I write a
new patch on it and paste it in below. Please help to review it.
Thanks
Haojian
From 26174b67184759ac2fe33748eeb43d3738732e21 Mon Sep 17 00:00:00 2001
From: Haojian Zhuang <haojian.zhuang@marvell•com>
Date: Thu, 8 Oct 2009 09:07:05 -0400
Subject: [PATCH] mfd: fix the dependancy of 88PM8607
88PM8607 module is dependant on I2C. I2C module must be built-in.
Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell•com>
---
drivers/mfd/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index fbe684b..00064e2 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -307,7 +307,7 @@ config EZX_PCAP
config MFD_88PM8607
bool "Support Marvell 88PM8607"
- depends on I2C
+ depends on I2C=y
select MFD_CORE
help
This supports for Marvell 88PM8607 Power Management IC. This includes
--
1.5.6.5
next prev parent reply other threads:[~2009-10-08 5:59 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 2:02 linux-next: mfd tree build failure Stephen Rothwell
2009-10-06 2:35 ` Haojian Zhuang
2009-10-06 3:54 ` Stephen Rothwell
2009-10-06 4:19 ` Haojian Zhuang
2009-10-08 5:59 ` Haojian Zhuang [this message]
2009-10-12 2:11 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2010-01-19 4:06 Stephen Rothwell
2010-01-19 10:59 ` Samuel Ortiz
2010-01-19 11:34 ` Stephen Rothwell
2010-01-11 5:02 Stephen Rothwell
2010-01-11 10:51 ` Mark Brown
2010-01-11 12:02 ` Haojian Zhuang
2010-01-11 12:33 ` Samuel Ortiz
2010-01-11 22:44 ` Stephen Rothwell
2009-11-24 5:37 Stephen Rothwell
2009-11-24 9:57 ` Mark Brown
2009-11-24 10:14 ` Stephen Rothwell
2009-11-24 10:40 ` Mark Brown
2009-11-23 3:41 Stephen Rothwell
2009-11-23 4:03 ` Stephen Rothwell
2009-11-23 12:29 ` Samuel Ortiz
2009-11-23 13:11 ` Mark Brown
2009-11-23 14:44 ` Samuel Ortiz
2009-11-23 15:20 ` Mark Brown
2009-11-23 3:35 Stephen Rothwell
2009-11-23 12:26 ` Samuel Ortiz
2009-11-23 16:32 ` Dmitry Torokhov
2009-11-24 23:35 ` Samuel Ortiz
2009-01-12 3:03 Stephen Rothwell
2009-01-12 10:07 ` Balaji Rao
2009-01-13 6:24 ` Stephen Rothwell
2009-01-14 12:12 ` Samuel Ortiz
2008-08-05 14:08 Stephen Rothwell
2008-08-05 15:39 ` ian
2008-08-05 16:05 ` Adrian Bunk
2008-08-05 18:50 ` ian
2008-08-05 16:05 ` Stephen Rothwell
2008-08-05 16:08 ` Samuel Ortiz
2008-08-05 16:16 ` Stephen Rothwell
2008-08-05 17:40 ` Samuel Ortiz
2008-08-05 18:46 ` ian
2008-08-06 9:53 ` Samuel Ortiz
2008-08-06 0:40 ` Stephen Rothwell
2008-08-05 5:09 Stephen Rothwell
2008-08-05 13:03 ` ian
2008-08-05 13:09 ` Samuel Ortiz
2008-08-05 13:22 ` Stephen Rothwell
2008-08-05 15:29 ` ian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=771cded00910072259m5aeaf900w376deb99b7f2b081@mail.gmail.com \
--to=haojian.zhuang@gmail$(echo .)com \
--cc=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sameo@openedhand$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox