From: Mike Frysinger <vapier.adi@gmail•com>
To: Rusty Russell <rusty@rustcorp•com.au>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
"Sachin P. Sant" <sachinp@in•ibm.com>,
linux-s390@vger•kernel.org, linux-next@vger•kernel.org,
LKML <linux-kernel@vger•kernel.org>,
schwidefsky@de•ibm.com, heiko.carstens@de•ibm.com
Subject: Re: [s390] next Feb 18: defconfig build break
Date: Wed, 18 Feb 2009 20:55:13 -0500 [thread overview]
Message-ID: <8bd0f97a0902181755y5a5f6760s6e266c87906e6dca@mail.gmail.com> (raw)
In-Reply-To: <200902190929.42044.rusty@rustcorp.com.au>
On Wed, Feb 18, 2009 at 17:59, Rusty Russell wrote:
> On Thursday 19 February 2009 03:40:59 Mike Frysinger wrote:
>> breaks all Blackfin ports as well:
>> In file included from include/linux/bitmap.h:9,
>> from include/linux/nodemask.h:90,
>> from include/linux/mmzone.h:17,
>> from include/linux/gfp.h:5,
>> from include/linux/kmod.h:23,
>> from include/linux/module.h:14,
>> from arch/blackfin/lib/strncmp.c:14:
>> include/linux/string.h: In function 'strstarts':
>> include/linux/string.h:124: error: implicit declaration of function 'strncmp'
>> make[1]: *** [arch/blackfin/lib/strncmp.o] Error 1
>> make: *** [arch/blackfin/lib] Error 2
>
> I don't have a blackfin cross compiler, but I think this is the right
> fix:
np ... fix is almost correct :)
> --- a/arch/blackfin/lib/strncmp.c
> +++ b/arch/blackfin/lib/strncmp.c
> @@ -6,6 +6,7 @@
> * Licensed under the GPL-2 or later.
> */
>
> +int strncmp(const char *cs, const char *ct, size_t count);
> #define strncmp __inline_strncmp
> #include <asm/string.h>
> #undef strncmp
> diff --git a/arch/blackfin/lib/strncpy.c b/arch/blackfin/lib/strncpy.c
> --- a/arch/blackfin/lib/strncpy.c
> +++ b/arch/blackfin/lib/strncpy.c
> @@ -6,6 +6,7 @@
> * Licensed under the GPL-2 or later.
> */
>
> +char *strncpy(char *dest, const char *src, size_t n);
> #define strncpy __inline_strncpy
> #include <asm/string.h>
> #undef strncpy
size_t is not a builtin type so there needs to be a linux/types.h
include right above these two prototypes. then things build up fine
for me.
thanks!
-mike
next prev parent reply other threads:[~2009-02-19 1:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 8:16 linux-next: Tree for February 18 Stephen Rothwell
2009-02-18 10:29 ` [s390] next Feb 18: defconfig build break Sachin P. Sant
2009-02-18 11:45 ` Stephen Rothwell
2009-02-18 17:10 ` Mike Frysinger
2009-02-18 22:43 ` Rusty Russell
2009-02-19 5:20 ` Sachin P. Sant
2009-02-20 10:23 ` Martin Schwidefsky
2009-02-18 22:59 ` Rusty Russell
2009-02-19 1:55 ` Mike Frysinger [this message]
2009-02-19 11:40 ` Rusty Russell
2009-02-19 17:14 ` Mike Frysinger
2009-02-19 0:15 ` Rusty Russell
2009-02-19 9:51 ` Russell King
2009-02-19 11:48 ` Rusty Russell
2009-02-18 18:02 ` [PATCH] module: fix build for CONFIG_SYSFS=n Randy Dunlap
2009-02-18 18:09 ` Ingo Molnar
2009-02-18 18:35 ` [PATCH v2] " Randy Dunlap
2009-02-18 19:15 ` Ingo Molnar
2009-02-19 10:50 ` Rusty Russell
2009-02-19 7:32 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0902181755y5a5f6760s6e266c87906e6dca@mail.gmail.com \
--to=vapier.adi@gmail$(echo .)com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=rusty@rustcorp$(echo .)com.au \
--cc=sachinp@in$(echo .)ibm.com \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox