From: Takashi Iwai <tiwai@suse•de>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Ingo Molnar <mingo@elte•hu>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Rusty Russell <rusty@rustcorp•com.au>
Subject: Re: [PATCH v2] module: fix build for CONFIG_SYSFS=n
Date: Thu, 19 Feb 2009 08:32:09 +0100 [thread overview]
Message-ID: <s5htz6qhog6.wl%tiwai@suse.de> (raw)
In-Reply-To: <499C54E8.7060004@oracle.com>
At Wed, 18 Feb 2009 10:35:20 -0800,
Randy Dunlap wrote:
>
> > Is destroy_params() dependent on SYSFS? If yes then it would be
>
> Yes.
>
> > far cleaner if there was a NOP destroy_params() inline for the
> > !SYSFS case.
>
>
>
>
> From: Randy Dunlap <randy.dunlap@oracle•com>
>
> Fix this build error when CONFIG_SYSFS=n:
>
> kernel/built-in.o: In function `free_module':
> module.c:(.text+0x4f8a2): undefined reference to `destroy_params'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
> cc: Rusty Russell <rusty@rustcorp•com.au>
> ---
> kernel/params.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> --- linux-next-20090218.orig/kernel/params.c
> +++ linux-next-20090218/kernel/params.c
> @@ -761,6 +761,12 @@ static int __init param_sysfs_init(void)
> }
> subsys_initcall(param_sysfs_init);
>
> +#else /* !CONFIG_SYSFS */
> +
> +inline void destroy_params(const struct kernel_param *params, unsigned num)
> +{
> +}
Just wondering whether any need to be (external) inline at this place,
supposing it just to be called from other files.
If inlining, isn't it better in include/linux/moduleparam.h?
thanks,
Takashi
prev parent reply other threads:[~2009-02-19 7:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 8:16 linux-next: Tree for February 18 Stephen Rothwell
2009-02-18 10:29 ` [s390] next Feb 18: defconfig build break Sachin P. Sant
2009-02-18 11:45 ` Stephen Rothwell
2009-02-18 17:10 ` Mike Frysinger
2009-02-18 22:43 ` Rusty Russell
2009-02-19 5:20 ` Sachin P. Sant
2009-02-20 10:23 ` Martin Schwidefsky
2009-02-18 22:59 ` Rusty Russell
2009-02-19 1:55 ` Mike Frysinger
2009-02-19 11:40 ` Rusty Russell
2009-02-19 17:14 ` Mike Frysinger
2009-02-19 0:15 ` Rusty Russell
2009-02-19 9:51 ` Russell King
2009-02-19 11:48 ` Rusty Russell
2009-02-18 18:02 ` [PATCH] module: fix build for CONFIG_SYSFS=n Randy Dunlap
2009-02-18 18:09 ` Ingo Molnar
2009-02-18 18:35 ` [PATCH v2] " Randy Dunlap
2009-02-18 19:15 ` Ingo Molnar
2009-02-19 10:50 ` Rusty Russell
2009-02-19 7:32 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htz6qhog6.wl%tiwai@suse.de \
--to=tiwai@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=rusty@rustcorp$(echo .)com.au \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox