From: "Gustavo A. R. Silva" <gustavo@embeddedor•com>
To: Krzysztof Kozlowski <krzk@kernel•org>,
"Gustavo A. R. Silva" <gustavoars@kernel•org>,
Tejun Heo <tj@kernel•org>, Zefan Li <lizefan.x@bytedance•com>,
Johannes Weiner <hannes@cmpxchg•org>
Cc: cgroups@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-hardening@vger•kernel.org,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Arnd Bergmann <arnd@arndb•de>,
"linux-samsung-soc@vger•kernel.org"
<linux-samsung-soc@vger•kernel.org>
Subject: Re: [PATCH][next] cgroup: Avoid -Wstringop-overflow warnings
Date: Thu, 22 Jun 2023 08:09:40 -0600 [thread overview]
Message-ID: <9b1f62bd-47b2-be64-4d09-7f6f2d52b3bc@embeddedor.com> (raw)
In-Reply-To: <361c2f87-1424-f452-912f-0e4a339f5c46@kernel.org>
Hi!
On 6/22/23 04:20, Krzysztof Kozlowski wrote:
> On 15/06/2023 03:18, Gustavo A. R. Silva wrote:
>> Address the following -Wstringop-overflow warnings seen when
>> built with ARM architecture and aspeed_g4_defconfig configuration
>> (notice that under this configuration CGROUP_SUBSYS_COUNT == 0):
>> kernel/cgroup/cgroup.c:1208:16: warning: 'find_existing_css_set' accessing 4 bytes in a region of size 0 [-Wstringop-overflow=]
>> kernel/cgroup/cgroup.c:1258:15: warning: 'css_set_hash' accessing 4 bytes in a region of size 0 [-Wstringop-overflow=]
>> kernel/cgroup/cgroup.c:6089:18: warning: 'css_set_hash' accessing 4 bytes in a region of size 0 [-Wstringop-overflow=]
>> kernel/cgroup/cgroup.c:6153:18: warning: 'css_set_hash' accessing 4 bytes in a region of size 0 [-Wstringop-overflow=]
>>
>
> Hi,
>
> This patch landed in next but causes boot failures on
> Exynos ARMv7 board (32 bit) with systemd (exynos_defconfig):
>
> NFS-Mount: 192.168.1.10:/srv/nfs/odroidhc1
> Waiting 10 seconds for device /dev/nfs ...
> ERROR: device '/dev/nfs' not found. Skipping fsck.
> Mount cmd:
> mount.nfs4 -o vers=4,nolock 192.168.1.10:/srv/nfs/odroidhc1 /new_root
> :: running cleanup hook [udev]
> [ 23.752917] systemd[1]: System time before build time, advancing clock.
> [ 23.851828] systemd[1]: Failed to mount tmpfs at /sys/fs/cgroup: No such file or directory
> [ 23.868459] systemd[1]: Failed to mount cgroup at /sys/fs/cgroup/systemd: No such file or directory
> [!!!!!!] Failed to mount API filesystems.
> [ 23.914562] systemd[1]: Freezing execution.
>
> Full log:
> https://krzk.eu/#/builders/21/builds/4110/steps/15/logs/serial0
Thanks for reporting this issue. I'll take a look.
--
Gustavo
prev parent reply other threads:[~2023-06-22 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ZIpm3pcs3iCP9UaR@work>
2023-06-22 10:20 ` [PATCH][next] cgroup: Avoid -Wstringop-overflow warnings Krzysztof Kozlowski
2023-06-22 14:09 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b1f62bd-47b2-be64-4d09-7f6f2d52b3bc@embeddedor.com \
--to=gustavo@embeddedor$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=cgroups@vger$(echo .)kernel.org \
--cc=gustavoars@kernel$(echo .)org \
--cc=hannes@cmpxchg$(echo .)org \
--cc=krzk@kernel$(echo .)org \
--cc=linux-hardening@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=lizefan.x@bytedance$(echo .)com \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox