* Re: [PATCH][next] cgroup: Avoid -Wstringop-overflow warnings
[not found] <ZIpm3pcs3iCP9UaR@work>
@ 2023-06-22 10:20 ` Krzysztof Kozlowski
2023-06-22 14:09 ` Gustavo A. R. Silva
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-22 10:20 UTC (permalink / raw)
To: Gustavo A. R. Silva, Tejun Heo, Zefan Li, Johannes Weiner
Cc: cgroups, linux-kernel, linux-hardening, Linux Next Mailing List,
Arnd Bergmann, linux-samsung-soc@vger•kernel.org
On 15/06/2023 03:18, Gustavo A. R. Silva wrote:
> Address the following -Wstringop-overflow warnings seen when
> built with ARM architecture and aspeed_g4_defconfig configuration
> (notice that under this configuration CGROUP_SUBSYS_COUNT == 0):
> kernel/cgroup/cgroup.c:1208:16: warning: 'find_existing_css_set' accessing 4 bytes in a region of size 0 [-Wstringop-overflow=]
> kernel/cgroup/cgroup.c:1258:15: warning: 'css_set_hash' accessing 4 bytes in a region of size 0 [-Wstringop-overflow=]
> kernel/cgroup/cgroup.c:6089:18: warning: 'css_set_hash' accessing 4 bytes in a region of size 0 [-Wstringop-overflow=]
> kernel/cgroup/cgroup.c:6153:18: warning: 'css_set_hash' accessing 4 bytes in a region of size 0 [-Wstringop-overflow=]
>
Hi,
This patch landed in next but causes boot failures on
Exynos ARMv7 board (32 bit) with systemd (exynos_defconfig):
NFS-Mount: 192.168.1.10:/srv/nfs/odroidhc1
Waiting 10 seconds for device /dev/nfs ...
ERROR: device '/dev/nfs' not found. Skipping fsck.
Mount cmd:
mount.nfs4 -o vers=4,nolock 192.168.1.10:/srv/nfs/odroidhc1 /new_root
:: running cleanup hook [udev]
[ 23.752917] systemd[1]: System time before build time, advancing clock.
[ 23.851828] systemd[1]: Failed to mount tmpfs at /sys/fs/cgroup: No such file or directory
[ 23.868459] systemd[1]: Failed to mount cgroup at /sys/fs/cgroup/systemd: No such file or directory
[!!!!!!] Failed to mount API filesystems.
[ 23.914562] systemd[1]: Freezing execution.
Full log:
https://krzk.eu/#/builders/21/builds/4110/steps/15/logs/serial0
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][next] cgroup: Avoid -Wstringop-overflow warnings
2023-06-22 10:20 ` [PATCH][next] cgroup: Avoid -Wstringop-overflow warnings Krzysztof Kozlowski
@ 2023-06-22 14:09 ` Gustavo A. R. Silva
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo A. R. Silva @ 2023-06-22 14:09 UTC (permalink / raw)
To: Krzysztof Kozlowski, Gustavo A. R. Silva, Tejun Heo, Zefan Li,
Johannes Weiner
Cc: cgroups, linux-kernel, linux-hardening, Linux Next Mailing List,
Arnd Bergmann, linux-samsung-soc@vger•kernel.org
Hi!
On 6/22/23 04:20, Krzysztof Kozlowski wrote:
> On 15/06/2023 03:18, Gustavo A. R. Silva wrote:
>> Address the following -Wstringop-overflow warnings seen when
>> built with ARM architecture and aspeed_g4_defconfig configuration
>> (notice that under this configuration CGROUP_SUBSYS_COUNT == 0):
>> kernel/cgroup/cgroup.c:1208:16: warning: 'find_existing_css_set' accessing 4 bytes in a region of size 0 [-Wstringop-overflow=]
>> kernel/cgroup/cgroup.c:1258:15: warning: 'css_set_hash' accessing 4 bytes in a region of size 0 [-Wstringop-overflow=]
>> kernel/cgroup/cgroup.c:6089:18: warning: 'css_set_hash' accessing 4 bytes in a region of size 0 [-Wstringop-overflow=]
>> kernel/cgroup/cgroup.c:6153:18: warning: 'css_set_hash' accessing 4 bytes in a region of size 0 [-Wstringop-overflow=]
>>
>
> Hi,
>
> This patch landed in next but causes boot failures on
> Exynos ARMv7 board (32 bit) with systemd (exynos_defconfig):
>
> NFS-Mount: 192.168.1.10:/srv/nfs/odroidhc1
> Waiting 10 seconds for device /dev/nfs ...
> ERROR: device '/dev/nfs' not found. Skipping fsck.
> Mount cmd:
> mount.nfs4 -o vers=4,nolock 192.168.1.10:/srv/nfs/odroidhc1 /new_root
> :: running cleanup hook [udev]
> [ 23.752917] systemd[1]: System time before build time, advancing clock.
> [ 23.851828] systemd[1]: Failed to mount tmpfs at /sys/fs/cgroup: No such file or directory
> [ 23.868459] systemd[1]: Failed to mount cgroup at /sys/fs/cgroup/systemd: No such file or directory
> [!!!!!!] Failed to mount API filesystems.
> [ 23.914562] systemd[1]: Freezing execution.
>
> Full log:
> https://krzk.eu/#/builders/21/builds/4110/steps/15/logs/serial0
Thanks for reporting this issue. I'll take a look.
--
Gustavo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-22 14:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <ZIpm3pcs3iCP9UaR@work>
2023-06-22 10:20 ` [PATCH][next] cgroup: Avoid -Wstringop-overflow warnings Krzysztof Kozlowski
2023-06-22 14:09 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox