From: Richard Holden <aciddeath@gmail•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] Remove unused variables from the cirrusfb driver
Date: Thu, 20 Nov 2008 23:12:42 -0700 [thread overview]
Message-ID: <DE425C06-700A-4042-B0AB-1CDE2134C4DF@gmail.com> (raw)
In-Reply-To: <20081121103409.fed9a837.sfr@canb.auug.org.au>
On Nov 20, 2008, at 4:34 PM, Stephen Rothwell wrote:
> Hi Richard,
>
> On Thu, 20 Nov 2008 11:03:22 -0700 "Richard A. Holden III" <aciddeath@gmail•com
> > wrote:
>>
>> Remove i and s vars from cirrusfb_setup as they are not used
>> anywhere in that function. This fixes 2 unused vars build warnings.
>
> Thanks for the patch, but this is already fixed in mainline (commit
> ee11940f8e7a2f064af22d52180cb5f9643eef61 "cirrusfb: remove unused
> variables").
>
> --
> Cheers,
> Stephen Rothwell sfr@canb•auug.org.au
> http://www.canb.auug.org.au/~sfr/
Am I right in assuming you pulled mainline before this commit for
next-20081120? I don't see the changelog in next and I'm getting the
build warnings still, but I can recheck this in the next version of
next.
-Richard Holden
next prev parent reply other threads:[~2008-11-21 6:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 18:03 [PATCH] Fix arch/x86/kernel/cpu/mtrr/main.c build warning Richard A. Holden III
2008-11-20 18:03 ` [PATCH] Remove unused variables from the cirrusfb driver Richard A. Holden III
2008-11-20 18:03 ` [PATCH] Remove unused variable from tlv320aic23 codec Richard A. Holden III
2008-11-20 18:56 ` Mark Brown
2008-11-24 13:24 ` [alsa-devel] " Takashi Iwai
2008-11-20 23:34 ` [PATCH] Remove unused variables from the cirrusfb driver Stephen Rothwell
2008-11-21 6:12 ` Richard Holden [this message]
2008-11-21 6:40 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DE425C06-700A-4042-B0AB-1CDE2134C4DF@gmail.com \
--to=aciddeath@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox