From: Takashi Iwai <tiwai@suse•de>
To: "Richard A. Holden III" <aciddeath@gmail•com>
Cc: linux-next@vger•kernel.org, alsa-devel@alsa-project•org,
Mark Brown <broonie@opensource•wolfsonmicro.com>,
linux-kernel@vger•kernel.org, Liam Girdwood <lrg@slimlogic•co.uk>
Subject: Re: [alsa-devel] [PATCH] Remove unused variable from tlv320aic23 codec
Date: Mon, 24 Nov 2008 14:24:27 +0100 [thread overview]
Message-ID: <s5hej11jlys.wl%tiwai@suse.de> (raw)
In-Reply-To: <1227204203-32112-3-git-send-email-aciddeath@gmail.com>
At Thu, 20 Nov 2008 11:03:23 -0700,
Richard A. Holden III wrote:
>
> Remove codec var from tlv320aic23_set_dai_sysclk, it is assigned to
> but never read.
>
> Signed-off-by: Richard A. Holden III <aciddeath@gmail•com>
>
> Cc: Jaroslav Kysela <perex@perex•cz>
> Cc: Takashi Iwai <tiwai@suse•de>
> Cc: Liam Girdwood <lrg@slimlogic•co.uk>
> Cc: Mark Brown <broonie@opensource•wolfsonmicro.com>
> Cc: alsa-devel@alsa-project•org
> ---
> sound/soc/codecs/tlv320aic23.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
This is already fixed in the upstream, but pretty differently.
Takashi
> diff --git a/sound/soc/codecs/tlv320aic23.c b/sound/soc/codecs/tlv320aic23.c
> index 44308da..45395d0 100644
> --- a/sound/soc/codecs/tlv320aic23.c
> +++ b/sound/soc/codecs/tlv320aic23.c
> @@ -421,8 +421,6 @@ static int tlv320aic23_set_dai_fmt(struct snd_soc_dai *codec_dai,
> static int tlv320aic23_set_dai_sysclk(struct snd_soc_dai *codec_dai,
> int clk_id, unsigned int freq, int dir)
> {
> - struct snd_soc_codec *codec = codec_dai->codec;
> -
> switch (freq) {
> case 12000000:
> return 0;
> --
> 1.5.6.4
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project•org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
next prev parent reply other threads:[~2008-11-24 13:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 18:03 [PATCH] Fix arch/x86/kernel/cpu/mtrr/main.c build warning Richard A. Holden III
2008-11-20 18:03 ` [PATCH] Remove unused variables from the cirrusfb driver Richard A. Holden III
2008-11-20 18:03 ` [PATCH] Remove unused variable from tlv320aic23 codec Richard A. Holden III
2008-11-20 18:56 ` Mark Brown
2008-11-24 13:24 ` Takashi Iwai [this message]
2008-11-20 23:34 ` [PATCH] Remove unused variables from the cirrusfb driver Stephen Rothwell
2008-11-21 6:12 ` Richard Holden
2008-11-21 6:40 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hej11jlys.wl%tiwai@suse.de \
--to=tiwai@suse$(echo .)de \
--cc=aciddeath@gmail$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=lrg@slimlogic$(echo .)co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox