From: Geert Uytterhoeven <geert@linux-m68k•org>
To: Ingo Molnar <mingo@elte•hu>
Cc: Alexey Dobriyan <adobriyan@gmail•com>,
Frederic Weisbecker <fweisbec@gmail•com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org,
Linux Kernel Development <linux-kernel@vger•kernel.org>,
Steven Rostedt <rostedt@goodmis•org>,
Linux/m68k <linux-m68k@vger•kernel.org>
Subject: Re: [PATCH] tracing: fix a build error on alpha and m68k
Date: Sat, 1 Nov 2008 11:16:52 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0811011116010.7456@anakin> (raw)
In-Reply-To: <20081031095544.GI30317@elte.hu>
On Fri, 31 Oct 2008, Ingo Molnar wrote:
> * Geert Uytterhoeven <geert@linux-m68k•org> wrote:
> > On Fri, 31 Oct 2008, Alexey Dobriyan wrote:
> > > On Thu, Oct 23, 2008 at 08:34:33PM +0400, Alexey Dobriyan wrote:
> > > > On Thu, Oct 23, 2008 at 07:27:48PM +0200, Frederic Weisbecker wrote:
> > > > > When tracing is enabled, some arch have included <linux/irqflags.h>
> > > > > on their <asm/system.h> but others like alpha or m68k don't.
> > > > >
> > > > > Build error on alpha:
> > > > >
> > > > > kernel/trace/trace.c: In function 'tracing_generic_entry_update':
> > > > > kernel/trace/trace.c:658: error: implicit declaration of function 'irqs_disabled_flags'
> > >
> > > FYI, this error still exists in mainline (7f82f000ed030d1108b4de47d9e2d556092980c6).
> >
> > Now it hit mainline (I can't be bothered to develop _new_ code to
> > fix things in -next ;-), I'm implementing irqs_disabled_flags() for
> > m68k. Stay tuned...
>
> this (now mainline) commit should have fixed it:
>
> 9244489: ftrace: handle archs that do not support irqs_disabled_flags
>
> can you still see problems?
Yes, the "undefined reference to `save_stack_trace'", as already pointed out
by Al. I'm trying his fix now...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k•org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2008-11-01 10:16 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 10:36 linux-next: Tree for October 23 Stephen Rothwell
2008-10-23 12:11 ` linux-next: kernel/trace/trace.c:658: error: Alexey Dobriyan
2008-10-23 12:48 ` Frédéric Weisbecker
2008-10-23 13:15 ` Frédéric Weisbecker
2008-10-23 14:41 ` Frederic Weisbecker
2008-10-23 14:37 ` Geert Uytterhoeven
2008-10-23 14:57 ` Frédéric Weisbecker
2008-10-23 15:30 ` Geert Uytterhoeven
2008-10-23 15:33 ` Frédéric Weisbecker
2008-10-23 17:27 ` [PATCH] tracing: fix a build error on alpha and m68k Frederic Weisbecker
2008-10-23 16:24 ` Frédéric Weisbecker
2008-10-23 16:34 ` Alexey Dobriyan
2008-10-23 16:35 ` Frédéric Weisbecker
2008-10-23 16:38 ` Ingo Molnar
2008-10-23 16:51 ` Frédéric Weisbecker
2008-10-23 16:55 ` Ingo Molnar
2008-10-23 17:06 ` Frédéric Weisbecker
2008-10-23 17:12 ` Steven Rostedt
2008-10-23 17:25 ` Frédéric Weisbecker
2008-10-24 14:16 ` Frederic Weisbecker
2008-10-24 13:42 ` [PATCH] ftrace: handle archs that do not support irqs_disabled_flags Steven Rostedt
2008-10-24 13:54 ` Frédéric Weisbecker
2008-10-25 8:24 ` Geert Uytterhoeven
2008-10-28 7:25 ` Greg Ungerer
2008-10-23 17:14 ` [PATCH] tracing: fix a build error on alpha and m68k Steven Rostedt
2008-10-30 21:49 ` Alexey Dobriyan
2008-10-30 22:57 ` Frédéric Weisbecker
2008-10-30 23:03 ` Ingo Molnar
2008-10-31 8:50 ` Geert Uytterhoeven
2008-10-31 9:55 ` Ingo Molnar
2008-11-01 10:16 ` Geert Uytterhoeven [this message]
2008-10-23 16:37 ` Ingo Molnar
2008-10-23 12:15 ` linux-next: arch/alpha/include/asm/smp.h:48:1: error: "cpu_possible_map" redefined Alexey Dobriyan
2008-10-23 12:16 ` Alexey Dobriyan
2008-10-23 15:10 ` Rusty Russell
2008-10-23 12:22 ` linux-next: include/linux/mmzone.h:288: error: 'CONFIG_NR_CPUS' undeclared here (not in a function) Alexey Dobriyan
2008-10-23 14:38 ` Geert Uytterhoeven
2008-10-23 12:26 ` linux-next: undefined reference to 'forbid_dac' Alexey Dobriyan
2008-10-23 13:16 ` FUJITA Tomonori
2008-10-23 12:57 ` linux-next: undefined reference to `nop_trace' Alexey Dobriyan
2008-10-23 13:07 ` linux-next: arch/s390/kernel/smp.c:120: error: request for member 'bits' in something not a structure or union Alexey Dobriyan
2008-10-23 14:14 ` linux-next: x86_64 UML broken Alexey Dobriyan
2008-10-23 14:48 ` linux-next: drivers/lguest/page_tables.c:1044: error: invalid initializer Alexey Dobriyan
2008-10-24 2:08 ` Rusty Russell
2008-10-24 0:18 ` linux-next: Tree for October 23 (cx88) Randy Dunlap
2008-10-24 1:04 ` linux-next: Tree for October 23 Randy Dunlap
2008-10-26 7:19 ` [ofa-general] " Or Gerlitz
2008-10-26 18:49 ` Randy Dunlap
2008-10-24 1:14 ` [PATCH] PCI hotplug printk format Randy Dunlap
2008-10-24 17:42 ` Jesse Barnes
2008-10-24 17:49 ` Jesse Barnes
2008-10-24 1:17 ` [PATCH] nfsctl: credentials error Randy Dunlap
2008-10-24 1:17 ` [PATCH] coda: " Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0811011116010.7456@anakin \
--to=geert@linux-m68k$(echo .)org \
--cc=adobriyan@gmail$(echo .)com \
--cc=fweisbec@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=rostedt@goodmis$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox