From: "Frédéric Weisbecker" <fweisbec@gmail•com>
To: Geert Uytterhoeven <geert@linux-m68k•org>
Cc: Alexey Dobriyan <adobriyan@gmail•com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Ingo Molnar <mingo@elte•hu>
Subject: Re: linux-next: kernel/trace/trace.c:658: error:
Date: Thu, 23 Oct 2008 17:33:26 +0200 [thread overview]
Message-ID: <c62985530810230833j5b9dd02atae2682a7962d4476@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0810231727430.18978@anakin>
2008/10/23 Geert Uytterhoeven <geert@linux-m68k•org>:
> On Thu, 23 Oct 2008, Frédéric Weisbecker wrote:
>> 2008/10/23 Geert Uytterhoeven <geert@linux-m68k•org>:
>> > If kernel/trace/trace.c calls irqs_disabled_flags(), it should include
>> > the include that defines irqs_disabled_flags(). You should not add it to
>> > some other random include.
>> >
>> > It's also happening on m68k:
>> > http://kisskb.ellerman.id.au/kisskb/buildresult/50641/
>>
>> The fact is that other archs include this header into their
>> asm/system.h. It seems that's because
>> they need some non-traced irq_save/restore .
>> I wanted to stay in the same approach because future use of
>> raw_local_irq could be used elsewhere
>> and seem to work perfectly whithout adding special headers on most
>> arch. But there will be some
>> bug report for each future use of these functions for alpha.... (and
>> even m68k as it seems).
>>
>> What do you think? Should I let this patch as is or send a new one
>> (and one other for m68k).
>
> kernel/trace/trace.c needs to include at least <linux/irqflags.h>, as
> that's where irqs_disabled_flags() is defined.
>
> If there are still other issues with the raw_local_irq(), IMHO they should be
> fixed separately.
>
> Hmm, what's this doing in <linux/irqflags.h>:
> | #ifdef CONFIG_TRACE_IRQFLAGS_SUPPORT
> | ...
> | #endif /* CONFIG_X86 */
> ^^^^^^^^^^
>
Ok, I will send a patch to correct in this way.
Thanks.
next prev parent reply other threads:[~2008-10-23 15:33 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 10:36 linux-next: Tree for October 23 Stephen Rothwell
2008-10-23 12:11 ` linux-next: kernel/trace/trace.c:658: error: Alexey Dobriyan
2008-10-23 12:48 ` Frédéric Weisbecker
2008-10-23 13:15 ` Frédéric Weisbecker
2008-10-23 14:41 ` Frederic Weisbecker
2008-10-23 14:37 ` Geert Uytterhoeven
2008-10-23 14:57 ` Frédéric Weisbecker
2008-10-23 15:30 ` Geert Uytterhoeven
2008-10-23 15:33 ` Frédéric Weisbecker [this message]
2008-10-23 17:27 ` [PATCH] tracing: fix a build error on alpha and m68k Frederic Weisbecker
2008-10-23 16:24 ` Frédéric Weisbecker
2008-10-23 16:34 ` Alexey Dobriyan
2008-10-23 16:35 ` Frédéric Weisbecker
2008-10-23 16:38 ` Ingo Molnar
2008-10-23 16:51 ` Frédéric Weisbecker
2008-10-23 16:55 ` Ingo Molnar
2008-10-23 17:06 ` Frédéric Weisbecker
2008-10-23 17:12 ` Steven Rostedt
2008-10-23 17:25 ` Frédéric Weisbecker
2008-10-24 14:16 ` Frederic Weisbecker
2008-10-24 13:42 ` [PATCH] ftrace: handle archs that do not support irqs_disabled_flags Steven Rostedt
2008-10-24 13:54 ` Frédéric Weisbecker
2008-10-25 8:24 ` Geert Uytterhoeven
2008-10-28 7:25 ` Greg Ungerer
2008-10-23 17:14 ` [PATCH] tracing: fix a build error on alpha and m68k Steven Rostedt
2008-10-30 21:49 ` Alexey Dobriyan
2008-10-30 22:57 ` Frédéric Weisbecker
2008-10-30 23:03 ` Ingo Molnar
2008-10-31 8:50 ` Geert Uytterhoeven
2008-10-31 9:55 ` Ingo Molnar
2008-11-01 10:16 ` Geert Uytterhoeven
2008-10-23 16:37 ` Ingo Molnar
2008-10-23 12:15 ` linux-next: arch/alpha/include/asm/smp.h:48:1: error: "cpu_possible_map" redefined Alexey Dobriyan
2008-10-23 12:16 ` Alexey Dobriyan
2008-10-23 15:10 ` Rusty Russell
2008-10-23 12:22 ` linux-next: include/linux/mmzone.h:288: error: 'CONFIG_NR_CPUS' undeclared here (not in a function) Alexey Dobriyan
2008-10-23 14:38 ` Geert Uytterhoeven
2008-10-23 12:26 ` linux-next: undefined reference to 'forbid_dac' Alexey Dobriyan
2008-10-23 13:16 ` FUJITA Tomonori
2008-10-23 12:57 ` linux-next: undefined reference to `nop_trace' Alexey Dobriyan
2008-10-23 13:07 ` linux-next: arch/s390/kernel/smp.c:120: error: request for member 'bits' in something not a structure or union Alexey Dobriyan
2008-10-23 14:14 ` linux-next: x86_64 UML broken Alexey Dobriyan
2008-10-23 14:48 ` linux-next: drivers/lguest/page_tables.c:1044: error: invalid initializer Alexey Dobriyan
2008-10-24 2:08 ` Rusty Russell
2008-10-24 0:18 ` linux-next: Tree for October 23 (cx88) Randy Dunlap
2008-10-24 1:04 ` linux-next: Tree for October 23 Randy Dunlap
2008-10-26 7:19 ` [ofa-general] " Or Gerlitz
2008-10-26 18:49 ` Randy Dunlap
2008-10-24 1:14 ` [PATCH] PCI hotplug printk format Randy Dunlap
2008-10-24 17:42 ` Jesse Barnes
2008-10-24 17:49 ` Jesse Barnes
2008-10-24 1:17 ` [PATCH] nfsctl: credentials error Randy Dunlap
2008-10-24 1:17 ` [PATCH] coda: " Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c62985530810230833j5b9dd02atae2682a7962d4476@mail.gmail.com \
--to=fweisbec@gmail$(echo .)com \
--cc=adobriyan@gmail$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox