* linux-next: build warning after merge of the mm-stable tree
@ 2023-08-22 6:53 Stephen Rothwell
2023-08-22 16:52 ` Andrew Morton
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2023-08-22 6:53 UTC (permalink / raw)
To: Andrew Morton
Cc: Matthew Wilcox (Oracle), Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
Hi all,
After merging the mm-stable tree, today's linux-next build (htmldocs)
produced this warning:
mm/hugetlb.c:1: warning: no structured comments found
Introduced by commit
9c5ccf2db04b ("mm: remove HUGETLB_PAGE_DTOR")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build warning after merge of the mm-stable tree
2023-08-22 6:53 linux-next: build warning after merge of the mm-stable tree Stephen Rothwell
@ 2023-08-22 16:52 ` Andrew Morton
2023-08-22 17:27 ` Matthew Wilcox
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2023-08-22 16:52 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Matthew Wilcox (Oracle), Linux Kernel Mailing List,
Linux Next Mailing List, Mike Kravetz
On Tue, 22 Aug 2023 16:53:55 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> Hi all,
>
> After merging the mm-stable tree, today's linux-next build (htmldocs)
> produced this warning:
>
> mm/hugetlb.c:1: warning: no structured comments found
>
> Introduced by commit
>
> 9c5ccf2db04b ("mm: remove HUGETLB_PAGE_DTOR")
Seems we removed the last /** comment from hugetlb.c.
Probably htmldocs just shouldn't warn about this.
otoh, hugetlb.c has undocumented EXPORT_SYMBOLs, so a nice
fix would be to document at least those interfaces....
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build warning after merge of the mm-stable tree
2023-08-22 16:52 ` Andrew Morton
@ 2023-08-22 17:27 ` Matthew Wilcox
0 siblings, 0 replies; 6+ messages in thread
From: Matthew Wilcox @ 2023-08-22 17:27 UTC (permalink / raw)
To: Andrew Morton
Cc: Stephen Rothwell, Linux Kernel Mailing List,
Linux Next Mailing List, Mike Kravetz
On Tue, Aug 22, 2023 at 09:52:43AM -0700, Andrew Morton wrote:
> Seems we removed the last /** comment from hugetlb.c.
Heh, yeah, two of my own patches colliding. That's what I get for
working on the mm in two different git trees at the same time.
> otoh, hugetlb.c has undocumented EXPORT_SYMBOLs, so a nice
> fix would be to document at least those interfaces....
Ask and ye shall receive. I decided not to document
linear_hugepage_index() since Sidhartha is deleting the only
user of it, and it was never an interface that was widely used.
Hopefully we're rid of PageHuge sometime soon.
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: build warning after merge of the mm-stable tree
@ 2025-01-16 6:05 Stephen Rothwell
2025-01-16 15:10 ` Suren Baghdasaryan
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2025-01-16 6:05 UTC (permalink / raw)
To: Andrew Morton
Cc: Suren Baghdasaryan, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
Hi all,
After merging the mm-stable tree, today's linux-next build (htmldocs)
produced this warning:
include/linux/seqlock.h:341: warning: Function parameter or struct member 'start' not described in 'raw_seqcount_try_begin'
Introduced by commit
dba4761a3e40 ("seqlock: add raw_seqcount_try_begin")
I seem to have missed this when it was first introduced, sorry.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build warning after merge of the mm-stable tree
2025-01-16 6:05 Stephen Rothwell
@ 2025-01-16 15:10 ` Suren Baghdasaryan
2025-01-16 18:29 ` Suren Baghdasaryan
0 siblings, 1 reply; 6+ messages in thread
From: Suren Baghdasaryan @ 2025-01-16 15:10 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Andrew Morton, Linux Kernel Mailing List, Linux Next Mailing List
On Wed, Jan 15, 2025 at 10:05 PM Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> Hi all,
>
> After merging the mm-stable tree, today's linux-next build (htmldocs)
> produced this warning:
>
> include/linux/seqlock.h:341: warning: Function parameter or struct member 'start' not described in 'raw_seqcount_try_begin'
Oops. Thanks for catching this! It should be:
@start: count to be passed to read_seqcount_retry()
Should I send a fixup to Andrew for inclusion into the mm tree?
>
> Introduced by commit
>
> dba4761a3e40 ("seqlock: add raw_seqcount_try_begin")
>
> I seem to have missed this when it was first introduced, sorry.
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build warning after merge of the mm-stable tree
2025-01-16 15:10 ` Suren Baghdasaryan
@ 2025-01-16 18:29 ` Suren Baghdasaryan
0 siblings, 0 replies; 6+ messages in thread
From: Suren Baghdasaryan @ 2025-01-16 18:29 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Andrew Morton, Linux Kernel Mailing List, Linux Next Mailing List
On Thu, Jan 16, 2025 at 7:10 AM Suren Baghdasaryan <surenb@google•com> wrote:
>
> On Wed, Jan 15, 2025 at 10:05 PM Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the mm-stable tree, today's linux-next build (htmldocs)
> > produced this warning:
> >
> > include/linux/seqlock.h:341: warning: Function parameter or struct member 'start' not described in 'raw_seqcount_try_begin'
>
> Oops. Thanks for catching this! It should be:
>
> @start: count to be passed to read_seqcount_retry()
>
> Should I send a fixup to Andrew for inclusion into the mm tree?
I posted the fix at
https://lore.kernel.org/all/20250116182730.801497-1-surenb@google.com/
in case it's needed.
>
> >
> > Introduced by commit
> >
> > dba4761a3e40 ("seqlock: add raw_seqcount_try_begin")
> >
> > I seem to have missed this when it was first introduced, sorry.
> >
> > --
> > Cheers,
> > Stephen Rothwell
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-01-16 18:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-22 6:53 linux-next: build warning after merge of the mm-stable tree Stephen Rothwell
2023-08-22 16:52 ` Andrew Morton
2023-08-22 17:27 ` Matthew Wilcox
-- strict thread matches above, loose matches on Subject: below --
2025-01-16 6:05 Stephen Rothwell
2025-01-16 15:10 ` Suren Baghdasaryan
2025-01-16 18:29 ` Suren Baghdasaryan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox