* Missing signoff in the hid tree
@ 2026-02-23 12:18 Mark Brown
2026-02-23 12:20 ` Jiri Kosina
0 siblings, 1 reply; 9+ messages in thread
From: Mark Brown @ 2026-02-23 12:18 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires; +Cc: linux-kernel, linux-next
[-- Attachment #1: Type: text/plain, Size: 138 bytes --]
Commit
6b409da663270 ("HID: magicmouse: fix battery reporting for Apple Magic Trackpad 2")
is missing a Signed-off-by from its author
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Missing signoff in the hid tree
2026-02-23 12:18 Mark Brown
@ 2026-02-23 12:20 ` Jiri Kosina
2026-02-23 18:08 ` Julius Lehmann
0 siblings, 1 reply; 9+ messages in thread
From: Jiri Kosina @ 2026-02-23 12:20 UTC (permalink / raw)
To: Mark Brown; +Cc: Benjamin Tissoires, linux-kernel, linux-next, Julius Lehmann
On Mon, 23 Feb 2026, Mark Brown wrote:
> Commit
>
> 6b409da663270 ("HID: magicmouse: fix battery reporting for Apple Magic Trackpad 2")
>
> is missing a Signed-off-by from its author
D'oh, thanks for spotting this.
CCing Julius -- could you please provide your Signed-off-by: line? I'll
take this as a sufficient reason to rebase the branch.
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Missing signoff in the hid tree
2026-02-23 12:20 ` Jiri Kosina
@ 2026-02-23 18:08 ` Julius Lehmann
2026-02-24 8:42 ` Jiri Kosina
0 siblings, 1 reply; 9+ messages in thread
From: Julius Lehmann @ 2026-02-23 18:08 UTC (permalink / raw)
To: Jiri Kosina, Mark Brown; +Cc: Benjamin Tissoires, linux-kernel, linux-next
On 2/23/26 13:20, Jiri Kosina wrote:
> On Mon, 23 Feb 2026, Mark Brown wrote:
>
>> Commit
>>
>> 6b409da663270 ("HID: magicmouse: fix battery reporting for Apple Magic Trackpad 2")
>>
>> is missing a Signed-off-by from its author
> D'oh, thanks for spotting this.
>
> CCing Julius -- could you please provide your Signed-off-by: line? I'll
> take this as a sufficient reason to rebase the branch.
sorry for messing up my commit, has been some time since my last mail patch.
Signed-off-by: Julius Lehmann<lehmanju@devpi•de>
>
> Thanks,
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Missing signoff in the hid tree
2026-02-23 18:08 ` Julius Lehmann
@ 2026-02-24 8:42 ` Jiri Kosina
0 siblings, 0 replies; 9+ messages in thread
From: Jiri Kosina @ 2026-02-24 8:42 UTC (permalink / raw)
To: Julius Lehmann; +Cc: Mark Brown, Benjamin Tissoires, linux-kernel, linux-next
On Mon, 23 Feb 2026, Julius Lehmann wrote:
> >> Commit
> >>
> >> 6b409da663270 ("HID: magicmouse: fix battery reporting for Apple Magic
> >> Trackpad 2")
> >>
> >> is missing a Signed-off-by from its author
> > D'oh, thanks for spotting this.
> >
> > CCing Julius -- could you please provide your Signed-off-by: line? I'll
> > take this as a sufficient reason to rebase the branch.
>
> sorry for messing up my commit, has been some time since my last mail patch.
>
> Signed-off-by: Julius Lehmann<lehmanju@devpi•de>
Thanks, I've now rebased for-7.0/upstream-fixes and for-next.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Missing signoff in the hid tree
@ 2026-03-20 12:30 Mark Brown
2026-03-30 22:12 ` Mark Brown
0 siblings, 1 reply; 9+ messages in thread
From: Mark Brown @ 2026-03-20 12:30 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires; +Cc: linux-kernel, linux-next
[-- Attachment #1: Type: text/plain, Size: 135 bytes --]
Commit
142068281f513 ("HID: input: use __free(kfree) to clean up temporary buffers")
is missing a Signed-off-by from its committer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Missing signoff in the hid tree
2026-03-20 12:30 Missing signoff in the hid tree Mark Brown
@ 2026-03-30 22:12 ` Mark Brown
2026-04-06 16:23 ` Mark Brown
0 siblings, 1 reply; 9+ messages in thread
From: Mark Brown @ 2026-03-30 22:12 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires; +Cc: linux-kernel, linux-next
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
On Fri, Mar 20, 2026 at 12:30:35PM +0000, Mark Brown wrote:
> Commit
>
> 142068281f513 ("HID: input: use __free(kfree) to clean up temporary buffers")
>
> is missing a Signed-off-by from its committer
This issue is still present today.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Missing signoff in the hid tree
2026-03-30 22:12 ` Mark Brown
@ 2026-04-06 16:23 ` Mark Brown
2026-04-06 16:38 ` Jiri Kosina
0 siblings, 1 reply; 9+ messages in thread
From: Mark Brown @ 2026-04-06 16:23 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires; +Cc: linux-kernel, linux-next
[-- Attachment #1: Type: text/plain, Size: 340 bytes --]
On Mon, Mar 30, 2026 at 11:12:37PM +0100, Mark Brown wrote:
> On Fri, Mar 20, 2026 at 12:30:35PM +0000, Mark Brown wrote:
> > Commit
> >
> > 142068281f513 ("HID: input: use __free(kfree) to clean up temporary buffers")
> >
> > is missing a Signed-off-by from its committer
>
> This issue is still present today.
And today.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Missing signoff in the hid tree
2026-04-06 16:23 ` Mark Brown
@ 2026-04-06 16:38 ` Jiri Kosina
2026-04-06 16:43 ` Mark Brown
0 siblings, 1 reply; 9+ messages in thread
From: Jiri Kosina @ 2026-04-06 16:38 UTC (permalink / raw)
To: Mark Brown; +Cc: Benjamin Tissoires, linux-kernel, linux-next
On Mon, 6 Apr 2026, Mark Brown wrote:
> > > 142068281f513 ("HID: input: use __free(kfree) to clean up temporary buffers")
> > >
> > > is missing a Signed-off-by from its committer
> >
> > This issue is still present today.
>
> And today.
Yeah, this happened because Benjamin rebased a tree with commit a that I
originally comitted and SOBed (the tree has a shared maintainership).
If you strongly believe that this is worth another rebase, I can happily
do that, but given the fact that it contains signoff of one of the
co-maintainers, I wouldn't lose sleep over it (but I can be probably
easily convinced otherwise).
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Missing signoff in the hid tree
2026-04-06 16:38 ` Jiri Kosina
@ 2026-04-06 16:43 ` Mark Brown
0 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2026-04-06 16:43 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Benjamin Tissoires, linux-kernel, linux-next
[-- Attachment #1: Type: text/plain, Size: 818 bytes --]
On Mon, Apr 06, 2026 at 06:38:14PM +0200, Jiri Kosina wrote:
> On Mon, 6 Apr 2026, Mark Brown wrote:
> > > > 142068281f513 ("HID: input: use __free(kfree) to clean up temporary buffers")
> > > > is missing a Signed-off-by from its committer
> > > This issue is still present today.
> > And today.
> Yeah, this happened because Benjamin rebased a tree with commit a that I
> originally comitted and SOBed (the tree has a shared maintainership).
This is a common way people mess up signoffs.
> If you strongly believe that this is worth another rebase, I can happily
> do that, but given the fact that it contains signoff of one of the
> co-maintainers, I wouldn't lose sleep over it (but I can be probably
> easily convinced otherwise).
That's more a question for Linus than for me.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-04-06 16:43 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-20 12:30 Missing signoff in the hid tree Mark Brown
2026-03-30 22:12 ` Mark Brown
2026-04-06 16:23 ` Mark Brown
2026-04-06 16:38 ` Jiri Kosina
2026-04-06 16:43 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2026-02-23 12:18 Mark Brown
2026-02-23 12:20 ` Jiri Kosina
2026-02-23 18:08 ` Julius Lehmann
2026-02-24 8:42 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox