From: Len Brown <lenb@kernel•org>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: Andi Kleen <andi@firstfloor•org>,
randy.dunlap@oracle•com, linux-acpi@vger•kernel.org,
linux-next@vger•kernel.org, Ingo Molnar <mingo@elte•hu>,
Arjan van de Ven <arjan@infradead•org>
Subject: Re: [PATCH -next] acpi utmisc: use WARN_ON() instead of warn_on_slowpath()
Date: Sun, 06 Jul 2008 13:18:56 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0807061307280.24417@localhost.localdomain> (raw)
In-Reply-To: <20080702141459.e6d6feaa.akpm@linux-foundation.org>
for background...
Ingo pointed out that automated testing wasn't finding
ACPI exceptions because we were not using the standard
Linux format for oops etc.
I put this hack patch on the debug-test branch in the acpi tree,
and pulled it into the test branch for linux-next to mine
for previously ignored errors.
This commit isn't intended for 2.6.27.
(and thus is not on the release-2.6.27 branch)
hopefully that isn't abuse of linux-next...
Arjan tells me that we'll have a real WARN()
with prink semantics in 2.6.27 and so we can
simplify/standardize this when that happens.
Oh, and since I'm on sabbatical, I'm obviously
fine with whatever Andi Kleen does (or does not do here)
in my absence.
thanks,
-Len
commit 9e030ab0bffdc8b6d8be663b639bd5e2374537f0
Author: Len Brown <len.brown@intel•com>
Date: Tue Jun 24 22:47:09 2008 -0400
ACPI: add standard linux WARN_ON() output to ACPI errors and
exceptions
In linux-2.6.27, we expect WARN() with printk semantics
to become available, and we'll be able to simplify
this code.
Signed-off-by: Len Brown <len.brown@intel•com>
next prev parent reply other threads:[~2008-07-06 17:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080701103339.b5acc1f3.randy.dunlap@oracle.com>
[not found] ` <20080701131714.5093fa49.akpm@linux-foundation.org>
[not found] ` <23433248.1214943818230.JavaMail.oracle@acsmt302.oracle.com>
[not found] ` <20080701133535.f92a673c.akpm@linux-foundation.org>
2008-07-02 18:28 ` [PATCH -next] acpi utmisc: use WARN_ON() instead of warn_on_slowpath() Randy Dunlap
2008-07-02 18:50 ` Andi Kleen
2008-07-02 19:14 ` Andrew Morton
2008-07-02 19:31 ` Andi Kleen
2008-07-02 19:43 ` Andrew Morton
2008-07-02 20:11 ` Andi Kleen
2008-07-02 20:35 ` Andrew Morton
2008-07-02 20:51 ` Andi Kleen
2008-07-02 21:02 ` Andrew Morton
2008-07-02 21:07 ` Andi Kleen
2008-07-02 21:14 ` Andrew Morton
2008-07-06 17:18 ` Len Brown [this message]
2008-07-06 18:13 ` Andi Kleen
2008-07-06 18:52 ` Arjan van de Ven
2008-07-07 6:19 ` Andi Kleen
2008-07-07 7:03 ` Arjan van de Ven
2008-07-08 15:44 ` Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0807061307280.24417@localhost.localdomain \
--to=lenb@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andi@firstfloor$(echo .)org \
--cc=arjan@infradead$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=randy.dunlap@oracle$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox