From: Andi Kleen <andi@firstfloor•org>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: randy.dunlap@oracle•com, lenb@kernel•org,
linux-acpi@vger•kernel.org, linux-next@vger•kernel.org
Subject: Re: [PATCH -next] acpi utmisc: use WARN_ON() instead of warn_on_slowpath()
Date: Wed, 02 Jul 2008 22:11:06 +0200 [thread overview]
Message-ID: <486BE0DA.2090108@firstfloor.org> (raw)
In-Reply-To: <20080702124316.61cc76e9.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
>
> Oh. I don't care much.
Thanks for the encouraging words.
> But acpi is presently causing build errors and
> is abusing core kernel internals. Please fix it.
>
> One way would be via printk() and dump_stack().
Here's a patch. Can you use that one instead of Randy's please?
-Andi
[-- Attachment #2: bug-fallback --]
[-- Type: text/plain, Size: 592 bytes --]
Supply warn_on_slow_path() even for the !CONFIG_BUG case
Fix build problem with ACPI for !CONFIG_BUG. Noted by Randy Dunlap.
Signed-off-by: Andi Kleen <ak@linux•intel.com>
diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
index 2632328..d0d83b7 100644
--- a/include/asm-generic/bug.h
+++ b/include/asm-generic/bug.h
@@ -63,6 +63,9 @@ extern void warn_on_slowpath(const char *file, const int line);
unlikely(__ret_warn_on); \
})
#endif
+
+static inline void warn_on_slowpath(const char *file, const int line) {}
+
#endif
#define WARN_ON_ONCE(condition) ({ \
next prev parent reply other threads:[~2008-07-02 20:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080701103339.b5acc1f3.randy.dunlap@oracle.com>
[not found] ` <20080701131714.5093fa49.akpm@linux-foundation.org>
[not found] ` <23433248.1214943818230.JavaMail.oracle@acsmt302.oracle.com>
[not found] ` <20080701133535.f92a673c.akpm@linux-foundation.org>
2008-07-02 18:28 ` [PATCH -next] acpi utmisc: use WARN_ON() instead of warn_on_slowpath() Randy Dunlap
2008-07-02 18:50 ` Andi Kleen
2008-07-02 19:14 ` Andrew Morton
2008-07-02 19:31 ` Andi Kleen
2008-07-02 19:43 ` Andrew Morton
2008-07-02 20:11 ` Andi Kleen [this message]
2008-07-02 20:35 ` Andrew Morton
2008-07-02 20:51 ` Andi Kleen
2008-07-02 21:02 ` Andrew Morton
2008-07-02 21:07 ` Andi Kleen
2008-07-02 21:14 ` Andrew Morton
2008-07-06 17:18 ` Len Brown
2008-07-06 18:13 ` Andi Kleen
2008-07-06 18:52 ` Arjan van de Ven
2008-07-07 6:19 ` Andi Kleen
2008-07-07 7:03 ` Arjan van de Ven
2008-07-08 15:44 ` Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486BE0DA.2090108@firstfloor.org \
--to=andi@firstfloor$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=lenb@kernel$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox