From: Len Brown <lenb@kernel•org>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
David Airlie <airlied@linux•ie>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
dri-devel@lists•freedesktop.org
Subject: Re: linux-next: Tree for May 6 (nouveau)
Date: Thu, 06 May 2010 16:37:46 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1005061636220.12696@localhost.localdomain> (raw)
In-Reply-To: <20100506111856.ae15cd03.randy.dunlap@oracle.com>
> When CONFIG_ACPI_BUTTON=m:
>
> drivers/built-in.o: In function `nouveau_connector_detect':
> nouveau_connector.c:(.text+0x1d81cf): undefined reference to `acpi_lid_open'
>
>
> #ifdef CONFIG_ACPI
> if (!nouveau_ignorelid && !acpi_lid_open())
> status = connector_status_unknown;
> #endif
>
>
> Do you want that to be
> #ifdef CONFIG_ACPI_BUTTON
> ?
> That will still only be built when CONFIG_ACPI_BUTTON=y (not =m).
>
intel_lvds.c seems to handle this issue without #ifdefs
by including acpi/button.h
cheers,
Len Brown, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-05-06 20:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 5:15 linux-next: Tree for May 6 Stephen Rothwell
2010-05-06 15:05 ` linux-next: Tree for May 6 (acpi: PM=n) Randy Dunlap
2010-05-06 20:26 ` [linux-pm] " Len Brown
2010-05-06 20:32 ` Randy Dunlap
2010-05-06 23:27 ` James Morris
2010-05-06 23:38 ` Randy Dunlap
2010-05-06 15:07 ` linux-next: Tree for May 6 (acpi: PCI=n) Randy Dunlap
2010-05-06 20:29 ` Len Brown
2010-05-06 20:42 ` Randy Dunlap
2010-05-06 18:18 ` linux-next: Tree for May 6 (nouveau) Randy Dunlap
2010-05-06 20:37 ` Len Brown [this message]
2010-05-06 23:41 ` [PATCH -next] IR: add header file to fix build Randy Dunlap
2010-05-06 23:43 ` [PATCH -next] staging: fix arlan build-braces Randy Dunlap
2010-05-11 21:13 ` Greg KH
2010-05-06 23:44 ` [PATCH -next] staging: fix cxt1e1 semaphore build breakage Randy Dunlap
2010-05-06 23:45 ` [PATCH -next] staging: fix ti-st, depends on RFKILL Randy Dunlap
2010-05-06 23:46 ` [PATCH -next] usb: fix u132-hcd code/data warning Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1005061636220.12696@localhost.localdomain \
--to=lenb@kernel$(echo .)org \
--cc=airlied@linux$(echo .)ie \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox