From: James Morris <jmorris@namei•org>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Len Brown <lenb@kernel•org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-pm@lists•linux-foundation.org, linux-acpi@vger•kernel.org,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Mimi Zohar <zohar@linux•vnet.ibm.com>,
Rajiv Andrade <srajiv@linux•vnet.ibm.com>
Subject: Re: [linux-pm] linux-next: Tree for May 6 (acpi: PM=n)
Date: Fri, 7 May 2010 09:27:49 +1000 (EST) [thread overview]
Message-ID: <alpine.LRH.2.00.1005070910490.31779@tundra.namei.org> (raw)
In-Reply-To: <20100506133215.f5dc579a.randy.dunlap@oracle.com>
On Thu, 6 May 2010, Randy Dunlap wrote:
> On Thu, 06 May 2010 16:26:13 -0400 (EDT) Len Brown wrote:
>
> > > When CONFIG_PM is not set:
> > >
> > > drivers/built-in.o: In function `acpi_init':
> > > bus.c:(.init.text+0x2d84): undefined reference to `pm_flags'
> > > bus.c:(.init.text+0x2d91): undefined reference to `pm_flags'
> >
> > CONFIG_ACPI depends on CONFIG_PM,
> > so acpi/bus.c should not be compiled for CONFIG_PM=n
> >
> > Hmm, is is somebody doing something strange, like "select ACPI"
> > without guaranteeing that all of ACPI's dependencies are satisfied?
>
> Oh, thanks for the clue.
>
> That would be a patch that I commented on and was ignored,
> but James Morris merged it anyway. Now it should be dropped.
>
> http://lkml.org/lkml/2010/5/4/379
You weren't ignored. Mimi responded and mentioned a subsequent patch,
after which, there was no further discussion.
I've reverted:
b89e66e1e396f7b5436af154e58209320cc08aed
"TPM: ACPI/PNP dependency removal"
a674fa46c79ffa37995bd1c8e4daa2b3be5a95ae
"ima: remove ACPI dependency"
Note: any further ACPI-related changes here should have acks from
linux-acpi folk.
- James
--
James Morris
<jmorris@namei•org>
next prev parent reply other threads:[~2010-05-06 23:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 5:15 linux-next: Tree for May 6 Stephen Rothwell
2010-05-06 15:05 ` linux-next: Tree for May 6 (acpi: PM=n) Randy Dunlap
2010-05-06 20:26 ` [linux-pm] " Len Brown
2010-05-06 20:32 ` Randy Dunlap
2010-05-06 23:27 ` James Morris [this message]
2010-05-06 23:38 ` Randy Dunlap
2010-05-06 15:07 ` linux-next: Tree for May 6 (acpi: PCI=n) Randy Dunlap
2010-05-06 20:29 ` Len Brown
2010-05-06 20:42 ` Randy Dunlap
2010-05-06 18:18 ` linux-next: Tree for May 6 (nouveau) Randy Dunlap
2010-05-06 20:37 ` Len Brown
2010-05-06 23:41 ` [PATCH -next] IR: add header file to fix build Randy Dunlap
2010-05-06 23:43 ` [PATCH -next] staging: fix arlan build-braces Randy Dunlap
2010-05-11 21:13 ` Greg KH
2010-05-06 23:44 ` [PATCH -next] staging: fix cxt1e1 semaphore build breakage Randy Dunlap
2010-05-06 23:45 ` [PATCH -next] staging: fix ti-st, depends on RFKILL Randy Dunlap
2010-05-06 23:46 ` [PATCH -next] usb: fix u132-hcd code/data warning Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.00.1005070910490.31779@tundra.namei.org \
--to=jmorris@namei$(echo .)org \
--cc=lenb@kernel$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-pm@lists$(echo .)linux-foundation.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=srajiv@linux$(echo .)vnet.ibm.com \
--cc=zohar@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox