* linux-next: build failure after merge of the final tree (acpi tree related)
@ 2010-05-24 3:41 Stephen Rothwell
2010-05-24 6:31 ` Len Brown
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2010-05-24 3:41 UTC (permalink / raw)
To: Len Brown; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
Hi Len,
After merging the final tree, today's linux-next build (i386 defconfig)
failed like this:
processor_driver.c:(.init.text+0x290b): undefined reference to `intel_idle_load_first'
Caused by commit 08ce7f9d5851216a4726ba9bc54a12a7d9bad392 ("intel_idle:
create a native cpuidle driver for select intel processors") from the acpi
tree.
I reverted that commit for today. (which revealed a typo in the commit
before that one (2828bdc92eeea6e9c79ffcb430f4b67e4ebd1559 "ACPI: allow a
native cpuidle driver to displace ACPI") so I reverted that as well.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: build failure after merge of the final tree (acpi tree related)
2010-05-24 3:41 linux-next: build failure after merge of the final tree (acpi tree related) Stephen Rothwell
@ 2010-05-24 6:31 ` Len Brown
2010-05-24 7:41 ` Stephen Rothwell
0 siblings, 1 reply; 7+ messages in thread
From: Len Brown @ 2010-05-24 6:31 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, Linux Kernel Mailing List
Hi Stephen,
Sorry for the trouble.
I've just now pushed fixes for those two build issues.
thanks,
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: build failure after merge of the final tree (acpi tree related)
2010-05-24 6:31 ` Len Brown
@ 2010-05-24 7:41 ` Stephen Rothwell
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Rothwell @ 2010-05-24 7:41 UTC (permalink / raw)
To: Len Brown; +Cc: linux-next, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 359 bytes --]
Hi Len,
On Mon, 24 May 2010 02:31:25 -0400 (EDT) Len Brown <lenb@kernel•org> wrote:
>
> I've just now pushed fixes for those two build issues.
Thanks.
Can you pick up the gfp/slab.h updates patch I sent you the other day,
as well, please.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* linux-next: build failure after merge of the final tree (acpi tree related)
@ 2013-02-11 7:34 Stephen Rothwell
2013-02-11 18:22 ` Bjorn Helgaas
2013-02-11 23:23 ` Len Brown
0 siblings, 2 replies; 7+ messages in thread
From: Stephen Rothwell @ 2013-02-11 7:34 UTC (permalink / raw)
To: Len Brown; +Cc: linux-next, linux-kernel, David S. Miller, sparclinux
[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]
Hi all,
After merging the final tree, today's linux-next build (sparc64 defconfig)
failed like this:
arch/sparc/include/asm/processor.h: Assembler messages:
arch/sparc/include/asm/processor.h:10: Error: Unknown opcode: `extern'
Caused by commit 3a242f58a5f4 ("sparc idle: rename pm_idle to
sparc_idle") from the acpi tree.
I have applied this patch for today:
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 11 Feb 2013 18:30:19 +1100
Subject: [PATCH] sparc idle: protect variable declarations against the assembler
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
arch/sparc/include/asm/processor.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/sparc/include/asm/processor.h b/arch/sparc/include/asm/processor.h
index 34baa35..622cfa5 100644
--- a/arch/sparc/include/asm/processor.h
+++ b/arch/sparc/include/asm/processor.h
@@ -7,6 +7,8 @@
#endif
#define nop() __asm__ __volatile__ ("nop")
+#ifndef __ASSEMBLY__
extern void (*sparc_idle)(void);
+#endif
#endif
--
1.8.1
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: linux-next: build failure after merge of the final tree (acpi tree related)
2013-02-11 7:34 Stephen Rothwell
@ 2013-02-11 18:22 ` Bjorn Helgaas
2013-02-11 23:23 ` Len Brown
1 sibling, 0 replies; 7+ messages in thread
From: Bjorn Helgaas @ 2013-02-11 18:22 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Len Brown, linux-next, linux-kernel, David S. Miller, sparclinux,
Rafael J. Wysocki
[+cc Rafael, since you mentioned the ACPI tree]
On Mon, Feb 11, 2013 at 12:34 AM, Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (sparc64 defconfig)
> failed like this:
>
> arch/sparc/include/asm/processor.h: Assembler messages:
> arch/sparc/include/asm/processor.h:10: Error: Unknown opcode: `extern'
>
> Caused by commit 3a242f58a5f4 ("sparc idle: rename pm_idle to
> sparc_idle") from the acpi tree.
>
> I have applied this patch for today:
>
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Mon, 11 Feb 2013 18:30:19 +1100
> Subject: [PATCH] sparc idle: protect variable declarations against the assembler
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> ---
> arch/sparc/include/asm/processor.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/sparc/include/asm/processor.h b/arch/sparc/include/asm/processor.h
> index 34baa35..622cfa5 100644
> --- a/arch/sparc/include/asm/processor.h
> +++ b/arch/sparc/include/asm/processor.h
> @@ -7,6 +7,8 @@
> #endif
>
> #define nop() __asm__ __volatile__ ("nop")
> +#ifndef __ASSEMBLY__
> extern void (*sparc_idle)(void);
> +#endif
>
> #endif
> --
> 1.8.1
>
> --
> Cheers,
> Stephen Rothwell sfr@canb•auug.org.au
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: build failure after merge of the final tree (acpi tree related)
2013-02-11 7:34 Stephen Rothwell
2013-02-11 18:22 ` Bjorn Helgaas
@ 2013-02-11 23:23 ` Len Brown
2013-02-12 17:35 ` Sam Ravnborg
1 sibling, 1 reply; 7+ messages in thread
From: Len Brown @ 2013-02-11 23:23 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Len Brown, linux-next, linux-kernel, David S. Miller, sparclinux
On 02/11/2013 02:34 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (sparc64 defconfig)
> failed like this:
>
> arch/sparc/include/asm/processor.h: Assembler messages:
> arch/sparc/include/asm/processor.h:10: Error: Unknown opcode: `extern'
>
> Caused by commit 3a242f58a5f4 ("sparc idle: rename pm_idle to
> sparc_idle") from the acpi tree.
>
> I have applied this patch for today:
>
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Mon, 11 Feb 2013 18:30:19 +1100
> Subject: [PATCH] sparc idle: protect variable declarations against the assembler
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> ---
> arch/sparc/include/asm/processor.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/sparc/include/asm/processor.h b/arch/sparc/include/asm/processor.h
> index 34baa35..622cfa5 100644
> --- a/arch/sparc/include/asm/processor.h
> +++ b/arch/sparc/include/asm/processor.h
> @@ -7,6 +7,8 @@
> #endif
>
> #define nop() __asm__ __volatile__ ("nop")
> +#ifndef __ASSEMBLY__
> extern void (*sparc_idle)(void);
> +#endif
>
> #endif
>
Thank you Stephen!
The last time I compiled a sparc kernel was in 1993:-)
I've added your fix and Dave's Ack to this patch,
and updated it in my next branch.
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: build failure after merge of the final tree (acpi tree related)
2013-02-11 23:23 ` Len Brown
@ 2013-02-12 17:35 ` Sam Ravnborg
0 siblings, 0 replies; 7+ messages in thread
From: Sam Ravnborg @ 2013-02-12 17:35 UTC (permalink / raw)
To: Len Brown
Cc: Stephen Rothwell, Len Brown, linux-next, linux-kernel,
David S. Miller, sparclinux
> > Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> > ---
> > arch/sparc/include/asm/processor.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/sparc/include/asm/processor.h b/arch/sparc/include/asm/processor.h
> > index 34baa35..622cfa5 100644
> > --- a/arch/sparc/include/asm/processor.h
> > +++ b/arch/sparc/include/asm/processor.h
> > @@ -7,6 +7,8 @@
> > #endif
> >
> > #define nop() __asm__ __volatile__ ("nop")
> > +#ifndef __ASSEMBLY__
> > extern void (*sparc_idle)(void);
> > +#endif
> >
> > #endif
> >
>
> Thank you Stephen!
>
> The last time I compiled a sparc kernel was in 1993:-)
>
> I've added your fix and Dave's Ack to this patch,
> and updated it in my next branch.
Hi Len.
Can you please move the definition of sparc_idle to processor_32.h
It is sparc32 specific - and then we do not need the __ASSEMBLY__ guards
as the sparc32 variant are not used from assembler.
Do you btw. have any hints how I can convert to the cpu_idle thing you hinted?
Sam
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-02-12 17:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-24 3:41 linux-next: build failure after merge of the final tree (acpi tree related) Stephen Rothwell
2010-05-24 6:31 ` Len Brown
2010-05-24 7:41 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2013-02-11 7:34 Stephen Rothwell
2013-02-11 18:22 ` Bjorn Helgaas
2013-02-11 23:23 ` Len Brown
2013-02-12 17:35 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox