From: Jiri Slaby <jirislaby@kernel•org>
To: Randy Dunlap <rdunlap@infradead•org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Greg KH <gregkh@linuxfoundation•org>
Cc: Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
linux-serial@vger•kernel.org
Subject: Re: linux-next: Tree for May 15 (config SERIAL_CPM)
Date: Thu, 18 May 2023 07:49:41 +0200 [thread overview]
Message-ID: <b16040e8-06f4-5c0e-7379-daa8226dc2a1@kernel.org> (raw)
In-Reply-To: <1538d954-864e-3a07-594a-dfe6d3178a72@infradead.org>
On 16. 05. 23, 4:51, Randy Dunlap wrote:
>
>
> On 5/14/23 21:12, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20230512:
>>
>
> commit e3e7b13bffae
> Author: Jiri Slaby <jirislaby@kernel•org>
> Date: Thu Apr 21 12:17:08 2022 +0200
>
> serial: allow COMPILE_TEST for some drivers
That commit should be reverted. I didn't realize it wouldn't link, while
it compiles fine.
> See this portion of that commit:
>
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -783,7 +783,7 @@ config SERIAL_PMACZILOG_CONSOLE
>
> config SERIAL_CPM
> tristate "CPM SCC/SMC serial port support"
> - depends on CPM2 || CPM1
> + depends on CPM2 || CPM1 || (PPC32 && COMPILE_TEST)
>
>
> When PPC32=y and COMPILE_TEST=y but CPM1 is not set and CPM2 is not set:
>
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_release_port':
> cpm_uart_core.c:(.text+0x598): undefined reference to `cpm_uart_freebuf'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_set_termios':
> cpm_uart_core.c:(.text+0x8e0): undefined reference to `__cpm2_setbrg'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_break_ctl':
> cpm_uart_core.c:(.text+0xb10): undefined reference to `cpm_line_cr_cmd'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0xb6c): undefined reference to `cpm_line_cr_cmd'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_startup':
> cpm_uart_core.c:(.text+0x1d48): undefined reference to `cpm_line_cr_cmd'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_request_port':
> cpm_uart_core.c:(.text+0x1ddc): undefined reference to `cpm_uart_allocbuf'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2170): undefined reference to `cpm_line_cr_cmd'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_probe':
> cpm_uart_core.c:(.text+0x2474): undefined reference to `cpm_uart_map_pram'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2724): undefined reference to `cpm_uart_unmap_pram'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2838): undefined reference to `cpm_uart_map_pram'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_shutdown':
> cpm_uart_core.c:(.text+0x2aa8): undefined reference to `cpm_line_cr_cmd'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2ba4): undefined reference to `cpm_line_cr_cmd'
>
>
--
js
suse labs
next prev parent reply other threads:[~2023-05-18 5:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 4:12 linux-next: Tree for May 15 Stephen Rothwell
2023-05-16 2:18 ` linux-next: Tree for May 15 (drivers/dma/ti/k3-udma.c) Randy Dunlap
2023-05-16 17:35 ` Vinod Koul
2023-05-16 2:23 ` linux-next: Tree for May 15 (net/ipv4/ipconfig.c:) Randy Dunlap
2023-05-18 3:57 ` David Ahern
2023-05-16 2:26 ` linux-next: Tree for May 15 (drivers/macintosh/ams/ams-core.c) Randy Dunlap
2023-05-16 2:40 ` linux-next: Tree for May 15 (drivers/tty/serial/8250/8250_omap.c) Randy Dunlap
2023-05-17 5:51 ` Tony Lindgren
2023-05-16 2:45 ` linux-next: Tree for May 15 (several RV64 build errors) Randy Dunlap
2023-05-16 6:18 ` Alexandre Ghiti
2023-05-19 10:42 ` Alexandre Ghiti
2023-05-19 11:22 ` Conor Dooley
2023-05-19 12:09 ` Alexandre Ghiti
2023-05-23 2:28 ` Randy Dunlap
2023-05-23 13:07 ` Alexandre Ghiti
2023-05-24 0:22 ` Randy Dunlap
2023-05-24 1:29 ` Palmer Dabbelt
2023-05-24 6:23 ` Arnd Bergmann
2023-05-24 22:41 ` Randy Dunlap
2023-05-24 22:49 ` Conor Dooley
2023-05-24 23:11 ` Palmer Dabbelt
2023-05-25 12:50 ` Conor Dooley
2023-05-16 2:51 ` linux-next: Tree for May 15 (config SERIAL_CPM) Randy Dunlap
2023-05-18 5:49 ` Jiri Slaby [this message]
2023-05-18 5:50 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b16040e8-06f4-5c0e-7379-daa8226dc2a1@kernel.org \
--to=jirislaby@kernel$(echo .)org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-serial@vger$(echo .)kernel.org \
--cc=rdunlap@infradead$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox