* Build failure on next-20250801
@ 2025-08-02 10:04 Konrad Dybcio
2025-08-02 15:30 ` Kent Overstreet
0 siblings, 1 reply; 2+ messages in thread
From: Konrad Dybcio @ 2025-08-02 10:04 UTC (permalink / raw)
To: Kent Overstreet; +Cc: Linux Next Mailing List, linux-bcachefs
Hi, just hit the below on next-20250801
Reverting
4c3205637f1e ("bcachefs: CLASS(btree_iter)")
...
69c862491582 ("Revert "bcachefs: Convert bch2_bkey_get_mut() to
CLASS(btree_iter)"")
(mostly as dependencies for clean reverts)
gets it to build again.
In case that matters (which I believe it doesn't), I'm using clang
on x86, version 20.1.8
fs/bcachefs/backpointers.c:391:7: error: cannot jump from this goto statement to its label
391 | if (fsck_err(trans, backpointer_to_missing_device,
| ^
fs/bcachefs/error.h:140:2: note: expanded from macro 'fsck_err'
140 | __fsck_err(c, FSCK_CAN_FIX|FSCK_CAN_IGNORE, _err_type, __VA_ARGS__)
| ^
fs/bcachefs/error.h:117:26: note: expanded from macro '__fsck_err'
117 | #define __fsck_err(...) fsck_err_wrap(bch2_fsck_err(__VA_ARGS__))
| ^
fs/bcachefs/error.h:111:3: note: expanded from macro 'fsck_err_wrap'
111 | goto fsck_err; \
| ^
fs/bcachefs/backpointers.c:398:20: note: jump bypasses initialization of variable with __attribute__((cleanup))
398 | CLASS(btree_iter, alloc_iter)(trans, BTREE_ID_alloc, bucket, 0);
| ^
1 error generated.
make[4]: *** [scripts/Makefile.build:287: fs/bcachefs/backpointers.o] Błąd 1
make[4]: *** Oczekiwanie na niezakończone zadania....
fs/bcachefs/alloc_background.c:2097:7: error: cannot jump from this goto statement to its label
2097 | if (fsck_err(trans, lru_entry_to_invalid_bucket,
| ^
fs/bcachefs/error.h:140:2: note: expanded from macro 'fsck_err'
140 | __fsck_err(c, FSCK_CAN_FIX|FSCK_CAN_IGNORE, _err_type, __VA_ARGS__)
| ^
fs/bcachefs/error.h:117:26: note: expanded from macro '__fsck_err'
117 | #define __fsck_err(...) fsck_err_wrap(bch2_fsck_err(__VA_ARGS__))
| ^
fs/bcachefs/error.h:111:3: note: expanded from macro 'fsck_err_wrap'
111 | goto fsck_err; \
| ^
fs/bcachefs/alloc_background.c:2107:20: note: jump bypasses initialization of variable with __attribute__((cleanup))
2107 | CLASS(btree_iter, alloc_iter)(trans, BTREE_ID_alloc, bucket, BTREE_ITER_cached);
| ^
1 error generated.
Konrad
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Build failure on next-20250801
2025-08-02 10:04 Build failure on next-20250801 Konrad Dybcio
@ 2025-08-02 15:30 ` Kent Overstreet
0 siblings, 0 replies; 2+ messages in thread
From: Kent Overstreet @ 2025-08-02 15:30 UTC (permalink / raw)
To: Konrad Dybcio; +Cc: Linux Next Mailing List, linux-bcachefs
On Sat, Aug 02, 2025 at 12:04:07PM +0200, Konrad Dybcio wrote:
> Hi, just hit the below on next-20250801
>
> Reverting
>
> 4c3205637f1e ("bcachefs: CLASS(btree_iter)")
> ...
> 69c862491582 ("Revert "bcachefs: Convert bch2_bkey_get_mut() to
> CLASS(btree_iter)"")
>
> (mostly as dependencies for clean reverts)
>
> gets it to build again.
Already have fixed versions in my for-next branch :)
>
>
> In case that matters (which I believe it doesn't), I'm using clang
> on x86, version 20.1.8
>
>
> fs/bcachefs/backpointers.c:391:7: error: cannot jump from this goto statement to its label
> 391 | if (fsck_err(trans, backpointer_to_missing_device,
> | ^
> fs/bcachefs/error.h:140:2: note: expanded from macro 'fsck_err'
> 140 | __fsck_err(c, FSCK_CAN_FIX|FSCK_CAN_IGNORE, _err_type, __VA_ARGS__)
> | ^
> fs/bcachefs/error.h:117:26: note: expanded from macro '__fsck_err'
> 117 | #define __fsck_err(...) fsck_err_wrap(bch2_fsck_err(__VA_ARGS__))
> | ^
> fs/bcachefs/error.h:111:3: note: expanded from macro 'fsck_err_wrap'
> 111 | goto fsck_err; \
> | ^
> fs/bcachefs/backpointers.c:398:20: note: jump bypasses initialization of variable with __attribute__((cleanup))
> 398 | CLASS(btree_iter, alloc_iter)(trans, BTREE_ID_alloc, bucket, 0);
> | ^
> 1 error generated.
> make[4]: *** [scripts/Makefile.build:287: fs/bcachefs/backpointers.o] Błąd 1
> make[4]: *** Oczekiwanie na niezakończone zadania....
> fs/bcachefs/alloc_background.c:2097:7: error: cannot jump from this goto statement to its label
> 2097 | if (fsck_err(trans, lru_entry_to_invalid_bucket,
> | ^
> fs/bcachefs/error.h:140:2: note: expanded from macro 'fsck_err'
> 140 | __fsck_err(c, FSCK_CAN_FIX|FSCK_CAN_IGNORE, _err_type, __VA_ARGS__)
> | ^
> fs/bcachefs/error.h:117:26: note: expanded from macro '__fsck_err'
> 117 | #define __fsck_err(...) fsck_err_wrap(bch2_fsck_err(__VA_ARGS__))
> | ^
> fs/bcachefs/error.h:111:3: note: expanded from macro 'fsck_err_wrap'
> 111 | goto fsck_err; \
> | ^
> fs/bcachefs/alloc_background.c:2107:20: note: jump bypasses initialization of variable with __attribute__((cleanup))
> 2107 | CLASS(btree_iter, alloc_iter)(trans, BTREE_ID_alloc, bucket, BTREE_ITER_cached);
> | ^
> 1 error generated.
>
>
> Konrad
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-02 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-02 10:04 Build failure on next-20250801 Konrad Dybcio
2025-08-02 15:30 ` Kent Overstreet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox