* Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths
[not found] ` <251c80d6-a2d0-4053-404f-bffd5a53313e@kernel.dk>
@ 2020-10-30 15:52 ` Qian Cai
2020-10-30 16:49 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Qian Cai @ 2020-10-30 15:52 UTC (permalink / raw)
To: Jens Axboe
Cc: Alexander Viro, linux-fsdevel, linux-kernel, Stephen Rothwell,
Linux Next Mailing List
On Fri, 2020-10-30 at 09:27 -0600, Jens Axboe wrote:
> On 10/30/20 9:24 AM, Qian Cai wrote:
> > We will need to call putname() before do_renameat2() returning -EINVAL
> > to avoid memory leaks.
>
> Thanks, should mention that this isn't final by any stretch (which is
> why it hasn't been posted yet), just pushed out for some exposure.
I don't know what other people think about this, but I do find a bit
discouraging in testing those half-baked patches in linux-next where it does not
even ready to post for a review.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=3c5499fa56f568005648e6e38201f8ae9ab88015
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths
2020-10-30 15:52 ` [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths Qian Cai
@ 2020-10-30 16:49 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-10-30 16:49 UTC (permalink / raw)
To: Qian Cai
Cc: Alexander Viro, linux-fsdevel, linux-kernel, Stephen Rothwell,
Linux Next Mailing List
On 10/30/20 9:52 AM, Qian Cai wrote:
> On Fri, 2020-10-30 at 09:27 -0600, Jens Axboe wrote:
>> On 10/30/20 9:24 AM, Qian Cai wrote:
>>> We will need to call putname() before do_renameat2() returning -EINVAL
>>> to avoid memory leaks.
>>
>> Thanks, should mention that this isn't final by any stretch (which is
>> why it hasn't been posted yet), just pushed out for some exposure.
>
> I don't know what other people think about this, but I do find a bit
> discouraging in testing those half-baked patches in linux-next where it does not
> even ready to post for a review.
I don't disagree with that and this doesn't normally happen. I don't
want to get into the reasonings, but things had to be shuffled which is
why they ended up in -next before being posted this week. They will go
out shortly.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-30 16:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20201030152407.43598-1-cai@redhat.com>
[not found] ` <251c80d6-a2d0-4053-404f-bffd5a53313e@kernel.dk>
2020-10-30 15:52 ` [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths Qian Cai
2020-10-30 16:49 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox