From: Grant Likely <grant.likely@secretlab•ca>
To: Sachin Sant <sachinp@in•ibm.com>
Cc: Linux/PPC Development <linuxppc-dev@ozlabs•org>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>,
Greg Kroah-Hartman <gregkh@suse•de>,
linux-kernel <linux-kernel@vger•kernel.org>
Subject: Re: -next Apr 30: OOPS during eHEA driver initialization
Date: Fri, 30 Apr 2010 11:43:22 -0600 [thread overview]
Message-ID: <g2mfa686aa41004301043i138ffb2dmac5b641fa3d512c4@mail.gmail.com> (raw)
In-Reply-To: <n2kfa686aa41004301035p7e15c017u7a1b98389cc1e466@mail.gmail.com>
On Fri, Apr 30, 2010 at 11:35 AM, Grant Likely
<grant.likely@secretlab•ca> wrote:
> On Fri, Apr 30, 2010 at 11:27 AM, Sachin Sant <sachinp@in•ibm.com> wrote:
>> Sachin Sant wrote:
>>>
>>> With today's next eHEA drivers fails to initialize.
>>
>> If i revert the following patch eHEA network interface is initialized
>> properly.
>>
>> commit cebfe0b6709abdab997c1a00499d67efa32ee1f0
>> drivercore: Add of_match_table to the common device drivers
>
> That is an easy one to fix. I'll get it updated today and send you the result.
Let me know if this patch fixes it:
Cheers,
g.
diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c
index ce957a4..693b0e6 100644
--- a/arch/powerpc/kernel/ibmebus.c
+++ b/arch/powerpc/kernel/ibmebus.c
@@ -201,6 +201,9 @@ static int ibmebus_create_devices(const struct
of_device_id *matches)
int ibmebus_register_driver(struct of_platform_driver *drv)
{
+ if (!drv->driver.of_match_table)
+ drv->driver.of_match_table = drv->match_table;
+
/* If the driver uses devices that ibmebus doesn't know, add them */
ibmebus_create_devices(drv->driver.of_match_table);
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2010-04-30 17:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 15:12 -next Apr 30: OOPS during eHEA driver initialization Sachin Sant
2010-04-30 17:27 ` Sachin Sant
2010-04-30 17:35 ` Grant Likely
2010-04-30 17:43 ` Grant Likely [this message]
2010-05-01 9:54 ` Sachin Sant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=g2mfa686aa41004301043i138ffb2dmac5b641fa3d512c4@mail.gmail.com \
--to=grant.likely@secretlab$(echo .)ca \
--cc=gregkh@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sachinp@in$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox