* Re: [PATCH v2 2/3] arm64: dts: hisilicon: hi3670: Add UFS controller support [not found] ` <20190105072859.9134-3-manivannan.sadhasivam@linaro.org> @ 2019-02-20 11:35 ` Thierry Reding 2019-02-20 14:21 ` Martin K. Petersen 0 siblings, 1 reply; 3+ messages in thread From: Thierry Reding @ 2019-02-20 11:35 UTC (permalink / raw) To: Martin K. Petersen Cc: Manivannan Sadhasivam, vinholikatti, jejb, liwei213, robh+dt, devicetree, guodong.xu, linux-scsi, linux-kernel, amit.kucheria, john.stultz, linux-arm-kernel, Wei Xu, linux-next [-- Attachment #1: Type: text/plain, Size: 2071 bytes --] On Sat, Jan 05, 2019 at 12:58:58PM +0530, Manivannan Sadhasivam wrote: > Add UFS controller support for HiSilicon HI3670 SoC. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro•org> > --- > arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) Hi Martin, it looks like you picked this up into the SCSI tree (perhaps inadvertently). It's been causing linux-next to fail to build since Monday (next-20190218) because it references a phandle (&crg_rst) that's not available. There's a patch on the mailing lists to add that, but I think at this point it'd be better if you could drop this from the SCSI tree and we let the HiSilicon maintainers deal with the dependency in their tree. Cc'ing Wei and linux-next. Thierry > > diff --git a/arch/arm64/boot/dts/hisilicon/hi3670.dtsi b/arch/arm64/boot/dts/hisilicon/hi3670.dtsi > index 6ccdf5040ffd..285219dd657f 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi3670.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi3670.dtsi > @@ -654,6 +654,24 @@ > clock-names = "apb_pclk"; > }; > > + /* UFS */ > + ufs: ufs@ff3c0000 { > + compatible = "hisilicon,hi3670-ufs", "jedec,ufs-2.1"; > + /* 0: HCI standard */ > + /* 1: UFS SYS CTRL */ > + reg = <0x0 0xff3c0000 0x0 0x1000>, > + <0x0 0xff3e0000 0x0 0x1000>; > + interrupt-parent = <&gic>; > + interrupts = <GIC_SPI 278 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&crg_ctrl HI3670_CLK_GATE_UFSIO_REF>, > + <&crg_ctrl HI3670_CLK_GATE_UFS_SUBSYS>; > + clock-names = "ref_clk", "phy_clk"; > + freq-table-hz = <0 0>, <0 0>; > + /* offset: 0x84; bit: 12 */ > + resets = <&crg_rst 0x84 12>; > + reset-names = "rst"; > + }; > + > /* SD */ > dwmmc1: dwmmc1@ff37f000 { > compatible = "hisilicon,hi3670-dw-mshc"; > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists•infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/3] arm64: dts: hisilicon: hi3670: Add UFS controller support 2019-02-20 11:35 ` [PATCH v2 2/3] arm64: dts: hisilicon: hi3670: Add UFS controller support Thierry Reding @ 2019-02-20 14:21 ` Martin K. Petersen 2019-04-15 16:00 ` Wei Xu 0 siblings, 1 reply; 3+ messages in thread From: Martin K. Petersen @ 2019-02-20 14:21 UTC (permalink / raw) To: Thierry Reding Cc: Martin K. Petersen, Manivannan Sadhasivam, vinholikatti, jejb, liwei213, robh+dt, devicetree, guodong.xu, linux-scsi, linux-kernel, amit.kucheria, john.stultz, linux-arm-kernel, Wei Xu, linux-next Hi Thierry, > it looks like you picked this up into the SCSI tree (perhaps > inadvertently). It's been causing linux-next to fail to build since > Monday (next-20190218) because it references a phandle (&crg_rst) > that's not available. I dropped the offending patch from the SCSI tree yesterday. When Stephen updates -next, things should be fine. -- Martin K. Petersen Oracle Linux Engineering ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/3] arm64: dts: hisilicon: hi3670: Add UFS controller support 2019-02-20 14:21 ` Martin K. Petersen @ 2019-04-15 16:00 ` Wei Xu 0 siblings, 0 replies; 3+ messages in thread From: Wei Xu @ 2019-04-15 16:00 UTC (permalink / raw) To: Martin K. Petersen, Thierry Reding Cc: Manivannan Sadhasivam, vinholikatti, jejb, liwei213, robh+dt, devicetree, guodong.xu, linux-scsi, linux-kernel, amit.kucheria, john.stultz, linux-arm-kernel, linux-next, xuwei5 Hi Manivannan, On 2/20/2019 2:21 PM, Martin K. Petersen wrote: > > Hi Thierry, > >> it looks like you picked this up into the SCSI tree (perhaps >> inadvertently). It's been causing linux-next to fail to build since >> Monday (next-20190218) because it references a phandle (&crg_rst) >> that's not available. > > I dropped the offending patch from the SCSI tree yesterday. When Stephen > updates -next, things should be fine. > Thanks! Applied the dts patch to the hisilicon dts tree. Best Regards, Wei ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-15 16:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190105072859.9134-1-manivannan.sadhasivam@linaro.org>
[not found] ` <20190105072859.9134-3-manivannan.sadhasivam@linaro.org>
2019-02-20 11:35 ` [PATCH v2 2/3] arm64: dts: hisilicon: hi3670: Add UFS controller support Thierry Reding
2019-02-20 14:21 ` Martin K. Petersen
2019-04-15 16:00 ` Wei Xu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox