From: Segher Boessenkool <segher@kernel•crashing.org>
To: Sergei Shtylyov <sshtylyov@ru•mvista.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs•org>, paulus@samba•org
Subject: Re: [PATCH] Fix I8042 IRQs on MPC8641 HPCN
Date: Wed, 20 Jun 2007 18:07:36 +0200 [thread overview]
Message-ID: <000737fbc16c8d25bb3ebcdc9bbd9eab@kernel.crashing.org> (raw)
In-Reply-To: <46795026.8040502@ru.mvista.com>
>>> * IRQ 9: Level
>>> * IRQ 10: Level
>>> * IRQ 11: Level
>>> - * IRQ 12: Level
>>> + * IRQ 12: Edge
>>> * IRQ 14: Edge
>>> * IRQ 15: Edge
>>> */
>>> - outb(0xfa, 0x4d0);
>>> - outb(0x1e, 0x4d1);
>>> + outb(0xf8, 0x4d0);
>>> + outb(0x0e, 0x4d1);
>> The comment doesn't mention IRQ13. You're changing IRQ9
>> to edge as well; is this an accident?
>
> Whare -- I'm only seeing bit 1 changing which corresponds to IRQ1
> and is reserved (0) anyway.
Uh yeah, bit 1, it's hard to count these single-byte quantities :-)
>> If not, you need to change the comment too.
Segher
next prev parent reply other threads:[~2007-06-20 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-20 0:15 [PATCH] Fix I8042 IRQs on MPC8641 HPCN Wade Farnsworth
2007-06-20 10:03 ` Segher Boessenkool
2007-06-20 16:04 ` Sergei Shtylyov
2007-06-20 16:07 ` Segher Boessenkool [this message]
2007-06-20 16:16 ` Wade Farnsworth
2007-06-20 16:22 ` Wade Farnsworth
2007-06-20 16:27 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=000737fbc16c8d25bb3ebcdc9bbd9eab@kernel.crashing.org \
--to=segher@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=sshtylyov@ru$(echo .)mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox