From: Michael Ellerman <michaelellerman@internode•on.net>
To: Haren Myneni <haren@us•ibm.com>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: _machine removal breaks kexec?
Date: Tue, 04 Apr 2006 07:40:48 +0200 [thread overview]
Message-ID: <1144129248.29756.7.camel@localhost.localdomain> (raw)
In-Reply-To: <44316705.1040202@us.ibm.com>
On Mon, 2006-04-03 at 11:18 -0700, Haren Myneni wrote:
> Basically, kexec-tools looks the platform property to determine whether
> to read tce-base, tce-size and htab-* properties. The attached patch
> find out the platform info based on /proc/device-tree/chosen/htab-base
> property. Not tested yet.
Why don't we get rid of the platform variable entirely in kexec-ppc64.c,
if the tce-* and htab-* properties are there, then we read them, if not
we don't.
There's also:
if (platform == PLATFORM_PSERIES) {
if (rmo_top > 0x30000000UL)
rmo_top = 0x30000000UL;
}
I'm not sure where that number comes from, perhaps we need to export the
RMO value like we do for the htab?
While we're there that code could use a function to read
a /proc/device-tree file and do error handling, there's a lot of
duplicate code at the moment.
cheers
--
Michael Ellerman
IBM OzLabs
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
next prev parent reply other threads:[~2006-04-04 5:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-03 1:40 _machine removal breaks kexec? Anton Blanchard
2006-04-03 16:16 ` Benjamin Herrenschmidt
2006-04-03 17:32 ` Kumar Gala
2006-04-03 18:18 ` Haren Myneni
2006-04-04 5:40 ` Michael Ellerman [this message]
2006-04-04 6:15 ` Haren Myneni
2006-04-04 12:05 ` Benjamin Herrenschmidt
2006-04-03 23:16 ` Segher Boessenkool
2006-04-04 0:43 ` Kumar Gala
2006-04-04 12:04 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1144129248.29756.7.camel@localhost.localdomain \
--to=michaelellerman@internode$(echo .)on.net \
--cc=haren@us$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox