From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Arnd Bergmann <arnd@arndb•de>
Cc: akpm@osdl•org, linuxppc-dev@ozlabs•org,
Sven Luther <sl@bplan-gmbh•de>,
tilmann@bitterberg•de
Subject: Re: [PATCH] enable RTAS /proc for PowerPC/CHRP platform
Date: Thu, 19 Oct 2006 08:39:55 +1000 [thread overview]
Message-ID: <1161211195.10524.15.camel@localhost.localdomain> (raw)
In-Reply-To: <200610180022.24631.arnd@arndb.de>
On Wed, 2006-10-18 at 00:22 +0200, Arnd Bergmann wrote:
> On Tuesday 17 October 2006 15:22, Christoph Hellwig wrote:
> > > rtas_node = of_find_node_by_name(NULL, "rtas");
> > > if (rtas_node == NULL)
> > > return -ENODEV;
> >
> > And given this check I wonder why we need the platform check at all. It
> > should be safe to just remove it.
> >
>
> One difference would be that it triggers on machines running SLOF (QS20,
> some JS20/JS21) and maybe some older Macs, which is probably a good
> thing.
Older macs may have bits of RTAS, but it doesn't work. I'd rather still
blacklist machine_is(powermac).
> I wonder if it should be a little stricter though:
>
> > rtas_node = of_find_node_by_path("/rtas");
> > if (!rtas_node)
> > return -ENODEV;
>
> In case there is a node called "rtas" somewhere else.
Yeah, just in case...
Ben.
next prev parent reply other threads:[~2006-10-18 22:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 11:29 [PATCH] enable RTAS /proc for PowerPC/CHRP platform Nicolas DET
2006-10-17 13:22 ` Christoph Hellwig
2006-10-17 22:22 ` Arnd Bergmann
2006-10-18 22:39 ` Benjamin Herrenschmidt [this message]
2006-10-20 8:13 ` Nicolas DET
2006-10-18 5:51 ` Nicolas DET
2006-10-18 6:05 ` Sven Luther
2006-10-18 6:15 ` Michael Ellerman
2006-10-18 6:34 ` Nicolas DET
2006-10-18 7:38 ` Olaf Hering
2006-10-18 22:38 ` Benjamin Herrenschmidt
2006-10-19 7:03 ` Olaf Hering
2006-10-19 23:35 ` Benjamin Herrenschmidt
2006-10-20 5:44 ` Olaf Hering
2006-10-20 5:56 ` Benjamin Herrenschmidt
2006-10-20 6:24 ` Sven Luther
2006-10-20 6:44 ` Olaf Hering
2006-10-20 6:58 ` Sven Luther
2006-10-20 7:12 ` Benjamin Herrenschmidt
2006-10-20 7:36 ` Sven Luther
2006-10-20 8:16 ` Benjamin Herrenschmidt
2006-10-20 7:20 ` Olaf Hering
2006-10-20 7:37 ` Sven Luther
2006-10-20 7:49 ` Olaf Hering
2006-10-20 8:12 ` Segher Boessenkool
2006-10-20 8:52 ` Sven Luther
2006-10-20 10:00 ` Olaf Hering
2006-10-20 13:59 ` Segher Boessenkool
2006-10-20 7:11 ` Benjamin Herrenschmidt
2006-10-20 7:14 ` Olaf Hering
2006-10-20 7:36 ` Benjamin Herrenschmidt
2006-10-20 10:01 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161211195.10524.15.camel@localhost.localdomain \
--to=benh@kernel$(echo .)crashing.org \
--cc=akpm@osdl$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sl@bplan-gmbh$(echo .)de \
--cc=tilmann@bitterberg$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox