From: Nicolas DET <nd@bplan-gmbh•de>
To: michael@ellerman•id.au
Cc: akpm@osdl•org, linuxppc-dev@ozlabs•org,
Sven Luther <sl@bplan-gmbh•de>,
tilmann@bitterberg•de
Subject: Re: [PATCH] enable RTAS /proc for PowerPC/CHRP platform
Date: Wed, 18 Oct 2006 08:34:04 +0200 [thread overview]
Message-ID: <4535CADC.5010100@bplan-gmbh.de> (raw)
In-Reply-To: <1161152109.7906.6.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]
Michael Ellerman wrote:
>> >> +#ifdef CONFIG_PPC64
>> >> +#define PROCRTAS_ROOT "ppc64"
>> >> +#else
>> >> +#define PROCRTAS_ROOT "ppc"
>> >
>> > Please don't do any pathname changes. Even if ppc64 isn't
correct it's
>> > what applications expect and what we should provide for a
coherent user
>> > interface.
>>
>> Humm, ok.
>> However, in this case 'ppc' (could be 32 or 64 as it is not specified)
>> is more generic than 'ppc64'.
>
> But it's called '/proc/ppc64' right now on lots of machines, so you
> can't go changing it.
Ok. No problem
>>
>> Indeed, however I can only test on CHRP. I'll remove the check in the
>> upcomming patch.
>
> That should be fine AFAICT, you should probably just check that each of
> the proc routines checks for errors - ie. just because you have an
> "/rtas" node doesn't mean you necessarily have "/rtas/set-indicator" or
> whatever.
ok
>
>> The patch also include a small code to create the /proc/ppc/rtas entry.
>> Should this be done here, or somewhere in arch/powerpc/chrp/setup.c ?
>
> That code is almost entirely the same as proc_ppc64_create(), so I think
> you should try and merge them - we want to minimise the number of
> foo_ppc64() and foo_ppc32() routines we have.
>
Ok.
proc_ppc64_create() is now locate in arch/powerpc/kernel/proc_ppc64.c.
Maybe a new file could be created (arch/powerpc/kernel/proc_ppc.c) ?
Any other suggestions?
Just indicate me the direction, and I would provide others patches.
Regards
[-- Attachment #2: nd.vcf --]
[-- Type: text/x-vcard, Size: 249 bytes --]
begin:vcard
fn:Nicolas DET ( bplan GmbH )
n:DET;Nicolas
org:bplan GmbH
adr:;;;;;;Germany
email;internet:nd@bplan-gmbh•de
title:Software Entwicklung
tel;work:+49 6171 9187 - 31
x-mozilla-html:FALSE
url:http://www.bplan-gmbh.de
version:2.1
end:vcard
next prev parent reply other threads:[~2006-10-18 6:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 11:29 [PATCH] enable RTAS /proc for PowerPC/CHRP platform Nicolas DET
2006-10-17 13:22 ` Christoph Hellwig
2006-10-17 22:22 ` Arnd Bergmann
2006-10-18 22:39 ` Benjamin Herrenschmidt
2006-10-20 8:13 ` Nicolas DET
2006-10-18 5:51 ` Nicolas DET
2006-10-18 6:05 ` Sven Luther
2006-10-18 6:15 ` Michael Ellerman
2006-10-18 6:34 ` Nicolas DET [this message]
2006-10-18 7:38 ` Olaf Hering
2006-10-18 22:38 ` Benjamin Herrenschmidt
2006-10-19 7:03 ` Olaf Hering
2006-10-19 23:35 ` Benjamin Herrenschmidt
2006-10-20 5:44 ` Olaf Hering
2006-10-20 5:56 ` Benjamin Herrenschmidt
2006-10-20 6:24 ` Sven Luther
2006-10-20 6:44 ` Olaf Hering
2006-10-20 6:58 ` Sven Luther
2006-10-20 7:12 ` Benjamin Herrenschmidt
2006-10-20 7:36 ` Sven Luther
2006-10-20 8:16 ` Benjamin Herrenschmidt
2006-10-20 7:20 ` Olaf Hering
2006-10-20 7:37 ` Sven Luther
2006-10-20 7:49 ` Olaf Hering
2006-10-20 8:12 ` Segher Boessenkool
2006-10-20 8:52 ` Sven Luther
2006-10-20 10:00 ` Olaf Hering
2006-10-20 13:59 ` Segher Boessenkool
2006-10-20 7:11 ` Benjamin Herrenschmidt
2006-10-20 7:14 ` Olaf Hering
2006-10-20 7:36 ` Benjamin Herrenschmidt
2006-10-20 10:01 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4535CADC.5010100@bplan-gmbh.de \
--to=nd@bplan-gmbh$(echo .)de \
--cc=akpm@osdl$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=michael@ellerman$(echo .)id.au \
--cc=sl@bplan-gmbh$(echo .)de \
--cc=tilmann@bitterberg$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox