From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Arnd Bergmann <arnd.bergmann@de•ibm.com>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org,
cbe-oss-dev@ozlabs•org, Anthony J Marsala <marsala@us•ibm.com>
Subject: Re: [Cbe-oss-dev] [PATCH] cell: use ppc_md->power_save instead of cbe_idle_loop
Date: Mon, 23 Oct 2006 20:16:27 +1000 [thread overview]
Message-ID: <1161598587.10524.455.camel@localhost.localdomain> (raw)
In-Reply-To: <200610231152.07675.arnd.bergmann@de.ibm.com>
> + /*
> + * We need to call cbe_enable_pause_zero on each CPU
> + * before first entering power_save(). The most convenient
> + * place for this is ppc_md->idle, because that is called
> + * right before entering the idle loop.
> + */
> + ppc_md.idle_loop = cbe_enable_pause_zero;
I disagree here... this should be done in setup_cpu() for non-boot CPUs,
and sometime in setup_arch for the boot CPU.
Another option is to have the pm_control bit done once for all CPUs at
boot in setup_arch() or such, and the TSC_CELL SPR bit done
unconditionally in powersave...
Ben.
next prev parent reply other threads:[~2006-10-23 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-20 16:40 Selecting the ppc_md.power_save method at boot time Arnd Bergmann
2006-10-20 22:05 ` Benjamin Herrenschmidt
2006-10-20 23:22 ` Olof Johansson
2006-10-23 9:52 ` [PATCH] cell: use ppc_md->power_save instead of cbe_idle_loop Arnd Bergmann
2006-10-23 10:16 ` Benjamin Herrenschmidt [this message]
2006-10-23 11:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161598587.10524.455.camel@localhost.localdomain \
--to=benh@kernel$(echo .)crashing.org \
--cc=arnd.bergmann@de$(echo .)ibm.com \
--cc=cbe-oss-dev@ozlabs$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=marsala@us$(echo .)ibm.com \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox