From: Grant Likely <grant.likely@secretlab•ca>
To: Sylvain Munaut <tnt@246tnt•com>,
linuxppc-embedded@ozlabs•org,
Benjamin Herrenschmidt <benh@kernel•crashing.org>
Subject: [PATCH] [POWERPC] Remove unneeded memset from mpc52xx_psc_uart probe function
Date: Wed, 1 Nov 2006 01:39:55 -0700 [thread overview]
Message-ID: <11623704072881-git-send-email-grant.likely@secretlab.ca> (raw)
In-Reply-To: <11623704073308-git-send-email-grant.likely@secretlab.ca>
This allows the console to continue to work after initializing the port
for full serial access. However, this is not a proper fix. The init
behaviour between console and serial driver access must be reengineered
Signed-off-by: Grant Likely <grant.likely@secretlab•ca>
---
drivers/serial/mpc52xx_uart.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/serial/mpc52xx_uart.c b/drivers/serial/mpc52xx_uart.c
index 09bf8e0..f194010 100644
--- a/drivers/serial/mpc52xx_uart.c
+++ b/drivers/serial/mpc52xx_uart.c
@@ -753,7 +753,6 @@ mpc52xx_uart_probe(struct of_device *op,
struct resource res;
int ret;
- printk("Got here!\n");
dev_dbg(&op->dev, "mpc52xx_uart_probe(op=%p, match=%p)\n", op, match);
/* Check validity & presence */
@@ -763,8 +762,6 @@ mpc52xx_uart_probe(struct of_device *op,
/* Init the port structure */
port = &mpc52xx_uart_ports[idx];
- memset(port, 0x00, sizeof(struct uart_port));
-
spin_lock_init(&port->lock);
port->fifosize = 512;
port->iotype = UPIO_MEM;
--
1.4.3.rc2.g0503
next prev parent reply other threads:[~2006-11-01 8:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 8:39 [RFC] Current Lite5200b patchset Grant Likely
2006-11-01 8:39 ` [PATCH] [POWERPC] Device tree for Freescale Lite5200(b) eval board Grant Likely
2006-11-01 8:39 ` [PATCH] [POWERPC] MPC52xx is a 6xx variant, remove PPC_52xx config option Grant Likely
2006-11-01 8:39 ` [PATCH] [POWERPC] Cleanup pegasos i8259 not in device tree workaround Grant Likely
2006-11-01 8:39 ` [PATCH] [POWERPC] whitespace cleanup Grant Likely
2006-11-01 8:39 ` [PATCH] [POWERPC] Move mpc52xx-psc uart driver to of_device from platform_device Grant Likely
2006-11-01 8:39 ` Grant Likely [this message]
2006-11-01 8:39 ` [PATCH] [POWERPC] Add support for lite5200b to arch/powerpc Grant Likely
2006-11-01 20:37 ` [PATCH] [POWERPC] Move mpc52xx-psc uart driver to of_device from platform_device Nicolas DET
2006-11-01 20:50 ` Grant Likely
2006-11-01 20:54 ` Nicolas DET
2006-11-01 19:47 ` [RFC] Current Lite5200b patchset Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11623704072881-git-send-email-grant.likely@secretlab.ca \
--to=grant.likely@secretlab$(echo .)ca \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=tnt@246tnt$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox