From: Nicolas DET <nd@bplan-gmbh•de>
To: Grant Likely <grant.likely@secretlab•ca>
Cc: linuxppc-embedded@ozlabs•org
Subject: Re: [PATCH] [POWERPC] Move mpc52xx-psc uart driver to of_device from platform_device
Date: Wed, 1 Nov 2006 21:54:37 +0100 (MET) [thread overview]
Message-ID: <45490971.8090908@bplan-gmbh.de> (raw)
In-Reply-To: <528646bc0611011250h6ce7d29al494ff94f891b0b07@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1706 bytes --]
Grant Likely wrote:
> On 11/1/06, Nicolas DET <nd@bplan-gmbh•de> wrote:
>> Grant Likely wrote:
>> > As part of the transition to arch/powerpc, this patch moves the
>> mpc5200 PSC
>> > driver over to the OF platform bus infrastructure.
>> >
>> > This patch is not acceptable for mainline as-is because it breaks
>> arch/ppc
>> > support for the mpc52xx. More rework is needed to allow it to
>> compile for
>> > either arch (or alternately, fork the driver)
>> >
>>
>> It has been hard to apply on 2.6.19-rc4 but it seems to perform well.
>> I add to add some entries in mpc52xx_uart_match[]
>
> Good news, thanks for the feedback. I take it you are able to use the
> serial port with this driver?
Yes.
>>
>> In now looks like this:
>> static struct of_device_id mpc52xx_uart_match[] = {
>> {
>> .name = "serial",
>> .compatible = "mpc52xx-psc",
>> },
>> {
>> .name = "serial",
>> .compatible = "mpc52xx-serial",
>> },
>> {
>> .name = "serial",
>> .compatible = "mpc5200-psc",
>> },
>> {
>> .name = "serial",
>> .compatible = "mpc5200-serial",
>> },
>> {},
>> };
>
> I'd rather not do this for the mainline code. I'd rather define a
> naming convention and all of us use it. We're early enough in this
> process that we can do that since there are only two major boards
> (lite5200 & Efika) on track to be supported in mainline ATM.
>
> Having 4 compatibility blocks to support 2 boards is over-engineering. :)
Ok. Efika will have "mpc5200-serial' inside the "compatible" property.
Regards,
[-- Attachment #2: nd.vcf --]
[-- Type: text/x-vcard, Size: 249 bytes --]
begin:vcard
fn:Nicolas DET ( bplan GmbH )
n:DET;Nicolas
org:bplan GmbH
adr:;;;;;;Germany
email;internet:nd@bplan-gmbh•de
title:Software Entwicklung
tel;work:+49 6171 9187 - 31
x-mozilla-html:FALSE
url:http://www.bplan-gmbh.de
version:2.1
end:vcard
next prev parent reply other threads:[~2006-11-01 20:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 8:39 [RFC] Current Lite5200b patchset Grant Likely
2006-11-01 8:39 ` [PATCH] [POWERPC] Device tree for Freescale Lite5200(b) eval board Grant Likely
2006-11-01 8:39 ` [PATCH] [POWERPC] MPC52xx is a 6xx variant, remove PPC_52xx config option Grant Likely
2006-11-01 8:39 ` [PATCH] [POWERPC] Cleanup pegasos i8259 not in device tree workaround Grant Likely
2006-11-01 8:39 ` [PATCH] [POWERPC] whitespace cleanup Grant Likely
2006-11-01 8:39 ` [PATCH] [POWERPC] Move mpc52xx-psc uart driver to of_device from platform_device Grant Likely
2006-11-01 8:39 ` [PATCH] [POWERPC] Remove unneeded memset from mpc52xx_psc_uart probe function Grant Likely
2006-11-01 8:39 ` [PATCH] [POWERPC] Add support for lite5200b to arch/powerpc Grant Likely
2006-11-01 20:37 ` [PATCH] [POWERPC] Move mpc52xx-psc uart driver to of_device from platform_device Nicolas DET
2006-11-01 20:50 ` Grant Likely
2006-11-01 20:54 ` Nicolas DET [this message]
2006-11-01 19:47 ` [RFC] Current Lite5200b patchset Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45490971.8090908@bplan-gmbh.de \
--to=nd@bplan-gmbh$(echo .)de \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox