From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Zang Roy-r61911 <tie-fei.zang@freescale•com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs•org>,
Paul Mackerras <paulus@samba•org>,
"Alexandre.Bounine@tundra•com" <Alexandre.Bounine@tundra•com>
Subject: Re: [PATCH] Powerpc: Make pci_read_irq_line the default: on mpc7448hpc2 board
Date: Tue, 14 Nov 2006 16:45:52 +1100 [thread overview]
Message-ID: <1163483152.5940.106.camel@localhost.localdomain> (raw)
In-Reply-To: <1163482111.3748.15.camel@localhost.localdomain>
Good. Same comments as with Vitaly though :-)
> +static void pci_irq_host_unmap(struct irq_host *h, unsigned int virq)
> +{
> + /* Make sure irq is masked in hardware */
> +
> + tsi108_pci_int_mask(virq);
> +
> + /* remove chip and handler */
> + set_irq_chip_and_handler(virq, NULL, NULL);
> +
> + /* Make sure it's completed */
> + synchronize_irq(virq);
> +}
You probably don't need that... the generic code should do the above
just fine unless something is wrong in which case we should fix it.
> +static int pci_irq_host_match(struct irq_host *h, struct device_node *node)
> +{
> + return pci_irq_node == NULL || pci_irq_node == node;
> +}
You probably don't want the NULL test here.
Cheers,
Ben.
next prev parent reply other threads:[~2006-11-14 5:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 3:18 [PATCH] Powerpc: Fix the warining message from the return value of function get_property Zang Roy-r61911
2006-10-27 11:51 ` [PATCH] Powerpc: Make pci_read_irq_line the default: on mpc7448hpc2 board Zang Roy-r61911
2006-10-27 14:51 ` Zang Roy-r61911
2006-11-14 5:28 ` Zang Roy-r61911
2006-11-14 5:45 ` Benjamin Herrenschmidt [this message]
2006-11-14 5:58 ` [PATCH] Powerpc: Make pci_read_irq_line the default: onmpc7448hpc2 board Zang Roy-r61911
2006-11-14 6:31 ` [PATCH - fix] Powerpc: Make pci_read_irq_line the default: on mpc7448hpc2 board Zang Roy-r61911
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163483152.5940.106.camel@localhost.localdomain \
--to=benh@kernel$(echo .)crashing.org \
--cc=Alexandre.Bounine@tundra$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=tie-fei.zang@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox