From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Tejun Heo <htejun@gmail•com>
Cc: linux-ide@vger•kernel.org, linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] drivers/ide: PATA driver for Celleb
Date: Tue, 21 Nov 2006 22:02:30 +1100 [thread overview]
Message-ID: <1164106951.5597.33.camel@localhost.localdomain> (raw)
In-Reply-To: <4562CFD4.6040702@gmail.com>
> > We use a drivers/ide driver because its design is more suitable for
> > SCC IDE controller than libata driver. Since SCC supports only 32bit
> > read/write, we must override many callbacks of ata_port_operations
> > by modifying generic helpers. Each time the libata common code is
> > updated, we must update those modified helpers. It is very hard for us.
> > But we will try to implement the libata driver as needed.
> >
> > This patch set is intended to be merged to 2.6.20.
> > If you have any comment, please write to me.
>
> Care to post libata version (even if it's not complete)? Let's work
> something out.
The main problem is error handling / reset code.
With the current libata, basically, you can only override the whole
thing pretty much at the toplevel. The problem is with things like
ata_std_prereset, ata_std_softreset and ata_std_postreset and callees.
We can either comletely re-implement them but that seems fairly dodgy to
me, or find a way to add hooks. At the end of the day, all they need is:
- write to the control register
- read & write of nsect_addr & lbal_addr
I wonder how much of these could be replaced by either a hook, or
taskfile accessors (possibly with a special flag).
Cheers,
Ben.
next prev parent reply other threads:[~2006-11-21 11:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200611210959.kAL9x8eH026223@toshiba.co.jp>
2006-11-21 10:07 ` [PATCH] drivers/ide: PATA driver for Celleb Tejun Heo
2006-11-21 11:02 ` Benjamin Herrenschmidt [this message]
2006-11-21 11:49 ` Alan
2006-11-21 10:01 Akira Iguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1164106951.5597.33.camel@localhost.localdomain \
--to=benh@kernel$(echo .)crashing.org \
--cc=htejun@gmail$(echo .)com \
--cc=linux-ide@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox