From: Alan <alan@lxorguk•ukuu.org.uk>
To: Akira Iguchi <akira2.iguchi@toshiba•co.jp>
Cc: linux-ide@vger•kernel.org, linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] drivers/ide: PATA driver for Celleb
Date: Tue, 21 Nov 2006 11:49:53 +0000 [thread overview]
Message-ID: <20061121114953.1443e7a1@localhost.localdomain> (raw)
In-Reply-To: <200611210959.kAL9x8eH026223@toshiba.co.jp>
> We use a drivers/ide driver because its design is more suitable for
> SCC IDE controller than libata driver. Since SCC supports only 32bit
Understand that drivers/ide will be going away at some point long term
but not for a while.
> read/write, we must override many callbacks of ata_port_operations
> by modifying generic helpers. Each time the libata common code is
> updated, we must update those modified helpers. It is very hard for us.
> But we will try to implement the libata driver as needed.
It would be good to do so - the future is libata. It may also help because
it may indicate places were libata not your code should change in order to
get a nicer interface.
> +/* PIO transfer mode table */
> +/* JCHST */
> +static unsigned long JCHSTtbl[2][7] = {
const...
> + switch (speed) {
> + case XFER_UDMA_6:
> + idx = 6;
> + break;
These values are carefully arranged so you can do
if (speed >= XFER_UDMA_0)
idx = speed - XFER_UDMA_0;
else
return 1;
Otherwise looks ready to merge.
Alan
next prev parent reply other threads:[~2006-11-21 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200611210959.kAL9x8eH026223@toshiba.co.jp>
2006-11-21 10:07 ` [PATCH] drivers/ide: PATA driver for Celleb Tejun Heo
2006-11-21 11:02 ` Benjamin Herrenschmidt
2006-11-21 11:49 ` Alan [this message]
2006-11-21 10:01 Akira Iguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061121114953.1443e7a1@localhost.localdomain \
--to=alan@lxorguk$(echo .)ukuu.org.uk \
--cc=akira2.iguchi@toshiba$(echo .)co.jp \
--cc=linux-ide@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox