public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Ishizaki Kou <kou.ishizaki@toshiba•co.jp>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH 13/19] powerpc: Supporting iommu for Celleb
Date: Thu, 18 Jan 2007 11:31:20 +1100	[thread overview]
Message-ID: <1169080280.4965.21.camel@localhost.localdomain> (raw)
In-Reply-To: <200701120113.l0C1D5WP000520@toshiba.co.jp>


> +static int __init celleb_init_iommu(void)
> +{

This needs a:

	if (!machine_is(celleb))
		return 0;

Since the initcall will always be called wether your platform was
selected at boot or not as long as it's built into the kernel.

> +	celleb_init_direct_mapping();
> +	pci_dma_ops = &dma_direct_ops;
> +	bus_register_notifier(&of_platform_bus_type, &celleb_of_bus_notifier);
> +
> +	return 0;
> +}
> +
> +arch_initcall(celleb_init_iommu);
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs•org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

  reply	other threads:[~2007-01-18  0:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-12  1:13 [PATCH 13/19] powerpc: Supporting iommu for Celleb Ishizaki Kou
2007-01-18  0:31 ` Benjamin Herrenschmidt [this message]
2007-01-18 12:10   ` Ishizaki Kou
  -- strict thread matches above, loose matches on Subject: below --
2006-12-14  2:43 Ishizaki Kou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1169080280.4965.21.camel@localhost.localdomain \
    --to=benh@kernel$(echo .)crashing.org \
    --cc=kou.ishizaki@toshiba$(echo .)co.jp \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=paulus@samba$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox