From: Will Schmidt <will_schmidt@vnet•ibm.com>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, Paul Mackerras <paulus@samba•org>
Subject: Re: [PATCH] [POWERPC] fix up log_plpar_hcall_return
Date: Wed, 07 Mar 2007 09:26:53 -0600 [thread overview]
Message-ID: <1173281214.13165.73.camel@localhost> (raw)
In-Reply-To: <1173278165.8635.0.camel@localhost.localdomain>
On Wed, 2007-07-03 at 15:36 +0100, Benjamin Herrenschmidt wrote:
> On Tue, 2007-03-06 at 17:11 -0600, Will Schmidt wrote:
> > This is mostly cosmetic. This updates log_plpar_hcall_return() to use a
> > case statement rather than an if-then-else jumble, and moves it to
> > rtas.c where it can be near the other rtas related functions.
>
> Except that this has nothing to do with RTAS or do I miss something ?
>
> Ben.
Hi Ben, hello to other folks too,
Milton made a similar comment via IRC.
I am likely blending the rtas/hcall terminology in a bad way, but will
clarify what I was thinking so someone can correct me. :-)
The lparcfg function is named log_plpar_hcall_return(), taking a hcall
return value and a string, and outputs a human-readable error message
that corresponds to that return value.
There is no hcall.c that this function would belong in. HvCall.S and
plpar_wrappers.h contain wrappers and the assembly code that does the
actual calls; but neither of those places look like good candidates for
this function.
The file rtas.c, however, does make some plpar_hcall function calls, and
has a number of the 900# magic numbers that *look* like the H_* defines
to me.
-Will
prev parent reply other threads:[~2007-03-07 15:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 23:11 [PATCH] [POWERPC] fix up log_plpar_hcall_return Will Schmidt
2007-03-07 0:12 ` Stephen Rothwell
2007-03-07 15:29 ` Will Schmidt
2007-03-07 14:36 ` Benjamin Herrenschmidt
2007-03-07 15:26 ` Will Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173281214.13165.73.camel@localhost \
--to=will_schmidt@vnet$(echo .)ibm.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox