From: Josh Boyer <jwboyer@linux•vnet.ibm.com>
To: Stephen Neuendorffer <stephen.neuendorffer@xilinx•com>
Cc: linuxppc-dev@ozlabs•org, microblaze-uclinux@itee•uq.edu.au,
Wolfgang Reissnegger <wre@xilinx•com>, Leonid <Leonid@a-k-a•net>
Subject: RE: [PATCH v2] Device tree bindings for Xilinx devices
Date: Tue, 16 Oct 2007 20:49:10 -0500 [thread overview]
Message-ID: <1192585750.13993.23.camel@localhost.localdomain> (raw)
In-Reply-To: <20071016232404.5F4D51130091@mail133-blu.bigfish.com>
On Tue, 2007-10-16 at 16:23 -0700, Stephen Neuendorffer wrote:
> It occurs to me that the 'compatible' bindings should probably be the
> name of the preferred driver for the device.
>
> > + l) Xilinx ML300 Framebuffer
> > + - compatible : Must include "xilinx,ml300-fb"
> Should probably be 'xilinxfb', and probably shouldn't reference ML300 at
> all.
>
> > + n) Xilinx EMAC and Xilinx TEMAC
> > +
> > + Xilinx Ethernet devices. Uses common properties from
> > other Ethernet
> > + devices with the following constraints:
> > +
> > + Required properties:
> > + - compatible : Must include one of: "xilinx,plb-temac",
> > + "xilinx,plb-emac", "xilinx-opb-emac"
> Should probably be just 'emac' and 'temac'.
You mean xilinx,emac and xilinx,temac, right? emac and temac are too
generic by themselves.
josh
next prev parent reply other threads:[~2007-10-17 2:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 15:53 [PATCH v2] Device tree bindings for Xilinx devices Grant Likely
2007-10-15 19:21 ` Arnd Bergmann
2007-10-15 19:54 ` Grant Likely
2007-10-16 18:24 ` Stephen Neuendorffer
2007-10-16 19:36 ` Grant Likely
2007-10-17 0:21 ` Stephen Neuendorffer
2007-10-17 2:35 ` Grant Likely
2007-10-17 3:03 ` Grant Likely
2007-10-16 23:23 ` Stephen Neuendorffer
2007-10-17 1:49 ` Josh Boyer [this message]
2007-10-17 2:31 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192585750.13993.23.camel@localhost.localdomain \
--to=jwboyer@linux$(echo .)vnet.ibm.com \
--cc=Leonid@a-k-a$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=microblaze-uclinux@itee$(echo .)uq.edu.au \
--cc=stephen.neuendorffer@xilinx$(echo .)com \
--cc=wre@xilinx$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox