From: Sergej Stepanov <Sergej.Stepanov@ids•de>
To: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] using mii-bitbang on different processor ports
Date: Tue, 30 Oct 2007 17:58:37 +0100 [thread overview]
Message-ID: <1193763517.6244.33.camel@p60635-ste.ids.de> (raw)
In-Reply-To: <20071030163200.GA4470@loki.buserror.net>
Hello Scott.
Thank you for reply.
Am Dienstag, den 30.10.2007, 11:32 -0500 schrieb Scott Wood:
> On Tue, Oct 30, 2007 at 05:09:19PM +0100, Sergej Stepanov wrote:
> You could just use of_iomap() for the second one, since we don't need
> the physical address for bus->id.
Nice tip.
Than it would be needless-------
|
\/
> > + iounmap(bitbang->mdc.dir);
> > + return -ENOMEM;
>
> Please use the goto-style error handling that's used elsewhere in the
> function.
Regards
Sergej.
next prev parent reply other threads:[~2007-10-30 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 16:09 [PATCH] using mii-bitbang on different processor ports Sergej Stepanov
2007-10-30 16:32 ` Scott Wood
2007-10-30 16:58 ` Sergej Stepanov [this message]
2007-10-30 17:16 ` Scott Wood
2007-10-31 2:50 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193763517.6244.33.camel@p60635-ste.ids.de \
--to=sergej.stepanov@ids$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox