From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: ppc-dev <linuxppc-dev@ozlabs•org>,
Dave Kleikamp <shaggy@linux•vnet.ibm.com>
Subject: Re: build error in powerpc tree
Date: Mon, 14 Jul 2008 18:39:03 +1000 [thread overview]
Message-ID: <1216024743.7549.266.camel@pasglop> (raw)
In-Reply-To: <20080714170301.93f940fd.sfr@canb.auug.org.au>
On Mon, 2008-07-14 at 17:03 +1000, Stephen Rothwell wrote:
> Hi Ben,
>
> Commit ef3d3246a0d06be622867d21af25f997aeeb105f ("powerpc/mm: Add Strong
> Access Ordering support") in the powerpc/{next,master} tree caused the
> following in a powerpc allmodconfig build:
>
> usr/include/asm/mman.h requires linux/mm.h, which does not exist in exported headers
>
> Also, that header file is now using CONFIG_PPC64 which we should not do
> in the unprotected (by #ifdef __KERNEL__) part an exported header file,
> we should use __powerpc64__ instead.
>
> I suspect all the CONFIG_PPC64 part of the file could be surrounded by
> #ifdef __KERNEL__ and the include of <linux/mm.h> could be moved to this
> section. The file should then be changed to unifdef-y from header-y in
> the Kbuild file. (Might have been easier to send a patch :-))
I'll dbl check tomorrow. PROT_SAO must be exported always but everything
else should pretty much be under __KERNEL__. Interesting that this
hasn't shown up in Paulus test build scripts that I used.
Cheers,
Ben.
next prev parent reply other threads:[~2008-07-14 8:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-14 7:03 build error in powerpc tree Stephen Rothwell
2008-07-14 8:39 ` Benjamin Herrenschmidt [this message]
2008-07-14 9:25 ` [PATCH] powerpc: mman.h export fixups Stephen Rothwell
2008-07-14 14:02 ` Arnd Bergmann
2008-07-14 16:34 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216024743.7549.266.camel@pasglop \
--to=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=shaggy@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox