From: Carl Love <cel@us•ibm.com>
To: oprofile-list@lists•sourceforge.net, linuxppc-dev@ozlabs•org,
cel@linux•vnet.ibm.com, cbe-oss-dev@ozlabs•org,
linux-kernel <linux-kernel@vger•kernel.org>
Subject: [Cbe-oss-dev] [PATCH] Cell OProfile: Incorrect local array size in activate spu profiling function
Date: Fri, 24 Oct 2008 11:47:29 -0700 [thread overview]
Message-ID: <1224874049.20229.5.camel@carll-linux-desktop> (raw)
The size of the pm_signal_local array should be equal to the
number of SPUs being configured in the call. Currently, the
array is of size 4 (NR_PHYS_CTRS) but being indexed by a for
loop from 0 to 7 (NUM_SPUS_PER_NODE).
Signed-off-by: Carl Love <carll@us•ibm.com>
Index: Cell_kernel_10_24_2008/arch/powerpc/oprofile/op_model_cell.c
===================================================================
--- Cell_kernel_10_24_2008.orig/arch/powerpc/oprofile/op_model_cell.c
+++ Cell_kernel_10_24_2008/arch/powerpc/oprofile/op_model_cell.c
@@ -830,7 +830,7 @@ static int calculate_lfsr(int n)
static int pm_rtas_activate_spu_profiling(u32 node)
{
int ret, i;
- struct pm_signal pm_signal_local[NR_PHYS_CTRS];
+ struct pm_signal pm_signal_local[NUM_SPUS_PER_NODE];
/*
* Set up the rtas call to configure the debug bus to
next reply other threads:[~2008-10-24 18:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 18:47 Carl Love [this message]
2008-10-25 4:39 ` [Cbe-oss-dev] [PATCH] Cell OProfile: Incorrect local array size in activate spu profiling function Michael Ellerman
2008-10-28 15:17 ` [UDATED PATCH] " Carl Love
2008-10-29 0:51 ` Michael Ellerman
2008-10-29 15:06 ` [UPDATED PATCH VER2] " Carl Love
2008-10-31 15:14 ` Robert Richter
2008-10-27 18:26 ` [Cbe-oss-dev] [PATCH] " Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224874049.20229.5.camel@carll-linux-desktop \
--to=cel@us$(echo .)ibm.com \
--cc=cbe-oss-dev@ozlabs$(echo .)org \
--cc=cel@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=oprofile-list@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox