From: Robert Richter <robert.richter@amd•com>
To: Carl Love <cel@us•ibm.com>
Cc: acjohnso <acjohnso@us•ibm.com>,
linux-kernel <linux-kernel@vger•kernel.org>,
Hannsj_uhl <Hannsj_uhl@de•ibm.com>,
linuxppc-dev@ozlabs•org, oprofile-list@lists•sourceforge.net,
Ingo Molnar <mingo@elte•hu>,
cel@linux•vnet.ibm.com, cbe-oss-dev@ozlabs•org
Subject: Re: [UPDATED PATCH VER2] Cell OProfile: Incorrect local array size in activate spu profiling function
Date: Fri, 31 Oct 2008 16:14:13 +0100 [thread overview]
Message-ID: <20081031151413.GE9785@erda.amd.com> (raw)
In-Reply-To: <1225292805.20229.52.camel@carll-linux-desktop>
On 29.10.08 08:06:45, Carl Love wrote:
> Updated the patch to address comments by Michael Ellerman.
> Specifically, changed upper limit in for loop to
> ARRAY_SIZE() macro and added a check to make sure the
> number of events specified by the user, which is used as
> the max for indexing various arrays, is no bigger then the
> declared size of the arrays.
>
> The size of the pm_signal_local array should be equal to the
> number of SPUs being configured in the array. Currently, the
> array is of size 4 (NR_PHYS_CTRS) but being indexed by a for
> loop from 0 to 7 (NUM_SPUS_PER_NODE).
>
> Signed-off-by: Carl Love <carll@us•ibm.com>
I applied your patch to oprofile/oprofile-for-tip. Thanks Carl.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd•com
next prev parent reply other threads:[~2008-10-31 15:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 18:47 [Cbe-oss-dev] [PATCH] Cell OProfile: Incorrect local array size in activate spu profiling function Carl Love
2008-10-25 4:39 ` Michael Ellerman
2008-10-28 15:17 ` [UDATED PATCH] " Carl Love
2008-10-29 0:51 ` Michael Ellerman
2008-10-29 15:06 ` [UPDATED PATCH VER2] " Carl Love
2008-10-31 15:14 ` Robert Richter [this message]
2008-10-27 18:26 ` [Cbe-oss-dev] [PATCH] " Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081031151413.GE9785@erda.amd.com \
--to=robert.richter@amd$(echo .)com \
--cc=Hannsj_uhl@de$(echo .)ibm.com \
--cc=acjohnso@us$(echo .)ibm.com \
--cc=cbe-oss-dev@ozlabs$(echo .)org \
--cc=cel@linux$(echo .)vnet.ibm.com \
--cc=cel@us$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mingo@elte$(echo .)hu \
--cc=oprofile-list@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox