From: Michael Ellerman <michael@ellerman•id.au>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs•org>
Subject: Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc
Date: Mon, 15 Jun 2009 22:36:02 +1000 [thread overview]
Message-ID: <1245069362.8735.15.camel@concordia> (raw)
In-Reply-To: <1245058807.12400.0.camel@pasglop>
[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]
On Mon, 2009-06-15 at 19:40 +1000, Benjamin Herrenschmidt wrote:
> > Currently this appears to break only one of the defconfigs, chrp32.
> >
> > http://kisskb.ellerman.id.au/kisskb/head/1907/
> >
> > And that's a legitimate error AFAICT:
> >
> > arch/powerpc/platforms/chrp/setup.c:378: error: the frame size of 1040 bytes is larger than 1024 bytes
> >
> > From:
> >
> > 367 void
> > 368 chrp_event_scan(unsigned long unused)
> > 369 {
> > 370 unsigned char log[1024];
> > 371 int ret = 0;
>
> I wonder to what extent we could merge that with the pSeries
> event-scan...
Yeah that occured to me, someone with a chrp machine would need to test
it, do we have one?
> We can have a closer look tomorrow. In any case, stack alloc for that is
> indeed fishy.
The obvious patch to make it static doesn't fly because it's called on
every cpu via a timer, so it needs to be a per-cpu at least I think. Or
borrow the pseries trick of calling it on each cpu in succession, or
just borrow the pseries code.
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-06-15 12:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 6:48 [PATCH] powerpc: Add configurable -Werror for arch/powerpc Michael Ellerman
2009-06-15 7:50 ` Michael Ellerman
2009-06-15 9:40 ` Benjamin Herrenschmidt
2009-06-15 12:36 ` Michael Ellerman [this message]
2009-06-15 21:23 ` Benjamin Herrenschmidt
2009-06-15 14:54 ` Timur Tabi
2009-06-18 14:22 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2009-04-07 2:00 Michael Ellerman
2009-04-07 2:27 ` Olof Johansson
2009-04-07 2:28 ` David Miller
2009-04-07 2:37 ` Olof Johansson
2009-04-07 3:01 ` Michael Ellerman
2009-04-07 14:11 ` Olof Johansson
2009-04-07 7:41 ` Geert Uytterhoeven
2009-04-07 7:50 ` Stephen Rothwell
2009-04-07 15:05 ` Kumar Gala
2009-04-06 4:18 Michael Ellerman
2009-04-06 12:55 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245069362.8735.15.camel@concordia \
--to=michael@ellerman$(echo .)id.au \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox