From: Scott Wood <scottwood@freescale•com>
To: Zhang Haijun <B42677@freescale•com>
Cc: linux-mmc@vger•kernel.org, AFLEMING@freescale•com,
Xie Xiaobo-R63061 <X.Xie@freescale•com>,
cbouatmailru@gmail•com, cjb@laptop•org,
linuxppc-dev@lists•ozlabs.org,
Haijun Zhang <Haijun.Zhang@freescale•com>
Subject: Re: [PATCH 1/3] mmc:core: parse voltage from device-tree
Date: Tue, 30 Jul 2013 14:58:54 -0500 [thread overview]
Message-ID: <1375214334.30721.82@snotra> (raw)
In-Reply-To: <51F71825.9000904@freescale.com> (from B42677@freescale.com on Mon Jul 29 20:34:29 2013)
On 07/29/2013 08:34:29 PM, Zhang Haijun wrote:
> On 07/30/2013 06:07 AM, Scott Wood wrote:
>> On 07/28/2013 09:56:33 PM, Haijun Zhang wrote:
>>> Add function to support get voltage from device-tree.
>>> If there are voltage-range specified in device-tree node, this =20
>>> function
>>> will parse it and return the avail voltage mask.
>>>=20
>>> Signed-off-by: Haijun Zhang <haijun.zhang@freescale•com>
>>> ---
>>> drivers/mmc/core/core.c | 48 =20
>>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>> include/linux/mmc/core.h | 1 +
>>> 2 files changed, 49 insertions(+)
>>=20
>> Move the code rather than copying it.
>>=20
>> -Scott
> Hi, Scott
>=20
> You mean?
The point of factoring this out is to avoid duplicating the code. If =20
you don't remove it from the place you copied it from (and have that =20
code call here instead), then you're not avoiding the duplication.
-Scott=
prev parent reply other threads:[~2013-07-30 19:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 2:56 [PATCH 1/3] mmc:core: parse voltage from device-tree Haijun Zhang
2013-07-29 2:56 ` [PATCH 2/3] mmc:sdhc: get voltage from sdhc host Haijun Zhang
2013-07-29 2:56 ` [PATCH 3/3] mmc:esdhc: add support to get voltage from device-tree Haijun Zhang
2013-07-29 22:07 ` [PATCH 1/3] mmc:core: parse " Scott Wood
2013-07-30 1:34 ` Zhang Haijun
2013-07-30 19:58 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375214334.30721.82@snotra \
--to=scottwood@freescale$(echo .)com \
--cc=AFLEMING@freescale$(echo .)com \
--cc=B42677@freescale$(echo .)com \
--cc=Haijun.Zhang@freescale$(echo .)com \
--cc=X.Xie@freescale$(echo .)com \
--cc=cbouatmailru@gmail$(echo .)com \
--cc=cjb@laptop$(echo .)org \
--cc=linux-mmc@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox