From: Christoph Hellwig <hch@lst•de>
To: ebony.zhu@freescale•com
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [patch][5/5] powerpc: Add the general support for Embedded Floating-Point instructions
Date: Fri, 12 Jan 2007 10:52:13 +0100 [thread overview]
Message-ID: <20070112095213.GA24536@lst.de> (raw)
In-Reply-To: <ZCH01EXM20D0kWSxlXp000006f8@zch01exm20.fsl.freescale.net>
On Fri, Jan 12, 2007 at 01:31:02PM +0800, ebony.zhu@freescale•com wrote:
> +ifeq ($(CONFIG_SPE),y)
> +ifneq ($(CONFIG_MATH_EMULATION),y)
> +core-y += arch/powerpc/math-emu/
> +endif
> +endif
> core-$(CONFIG_MATH_EMULATION) += arch/powerpc/math-emu/
This statement doesn't make any sense. I guess you always want to
build arch/powerpc/math-emu if CONFIG_SPE is set, right? The proper
way to do that is to force CONFIG_MATH_EMULATION in the Kconfig.
Then again we need a really good explanation why CONFIG_SPE should
force the math emulation to be built.
next prev parent reply other threads:[~2007-01-12 9:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-12 5:31 [patch][5/5] powerpc: Add the general support for Embedded Floating-Point instructions ebony.zhu
2007-01-12 6:40 ` Kumar Gala
2007-01-12 7:45 ` Zhu Ebony-r57400
2007-01-12 11:05 ` Benjamin Herrenschmidt
2007-01-12 18:39 ` Kumar Gala
2007-01-12 20:52 ` Benjamin Herrenschmidt
2007-01-12 21:18 ` Kumar Gala
2007-01-12 21:27 ` Benjamin Herrenschmidt
2007-01-12 21:49 ` Kumar Gala
2007-01-12 22:02 ` Benjamin Herrenschmidt
2007-01-16 9:43 ` Zhu Ebony-r57400
2007-01-16 21:54 ` Benjamin Herrenschmidt
2007-01-15 8:06 ` [patch][5/5] powerpc: Add the general support for EmbeddedFloating-Point instructions Zhu Ebony-r57400
2007-01-12 18:53 ` [patch][5/5] powerpc: Add the general support for Embedded Floating-Point instructions Kumar Gala
2007-01-15 7:48 ` Zhu Ebony-r57400
2007-01-12 9:52 ` Christoph Hellwig [this message]
2007-01-12 10:23 ` Zhu Ebony-r57400
2007-01-12 12:36 ` Segher Boessenkool
2007-01-15 7:58 ` Zhu Ebony-r57400
2007-01-12 18:57 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070112095213.GA24536@lst.de \
--to=hch@lst$(echo .)de \
--cc=ebony.zhu@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox