public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
* [POWERPC] wire up sys_epoll_pwait
@ 2007-02-21  4:36 Stephen Rothwell
  2007-02-21  9:36 ` Arnd Bergmann
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2007-02-21  4:36 UTC (permalink / raw)
  To: paulus; +Cc: ppc-dev



Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
 include/asm-powerpc/systbl.h |    1 +
 include/asm-powerpc/unistd.h |    3 ++-
 2 files changed, 3 insertions(+), 1 deletions(-)

This patch depends on the patch that adds compat_sys_epoll_pwait.
-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au

diff --git a/include/asm-powerpc/systbl.h b/include/asm-powerpc/systbl.h
index 418e5c7..85ab356 100644
--- a/include/asm-powerpc/systbl.h
+++ b/include/asm-powerpc/systbl.h
@@ -306,3 +306,4 @@ COMPAT_SYS_SPU(get_robust_list)
 COMPAT_SYS_SPU(set_robust_list)
 COMPAT_SYS(move_pages)
 SYSCALL_SPU(getcpu)
+COMPAT_SYS_SPU(epoll_pwait)
diff --git a/include/asm-powerpc/unistd.h b/include/asm-powerpc/unistd.h
index bcc21bf..2baedbe 100644
--- a/include/asm-powerpc/unistd.h
+++ b/include/asm-powerpc/unistd.h
@@ -325,10 +325,11 @@
 #define __NR_set_robust_list	300
 #define __NR_move_pages		301
 #define __NR_getcpu		302
+#define __NR_epoll_pwait	303
 
 #ifdef __KERNEL__
 
-#define __NR_syscalls		303
+#define __NR_syscalls		304
 
 #define __NR__exit __NR_exit
 #define NR_syscalls	__NR_syscalls
-- 
1.4.4.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [POWERPC] wire up sys_epoll_pwait
  2007-02-21  4:36 [POWERPC] wire up sys_epoll_pwait Stephen Rothwell
@ 2007-02-21  9:36 ` Arnd Bergmann
  0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2007-02-21  9:36 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Stephen Rothwell, paulus

On Wednesday 21 February 2007 05:36, Stephen Rothwell wrote:
> @@ -306,3 +306,4 @@ COMPAT_SYS_SPU(get_robust_list)
> =A0COMPAT_SYS_SPU(set_robust_list)
> =A0COMPAT_SYS(move_pages)
> =A0SYSCALL_SPU(getcpu)
> +COMPAT_SYS_SPU(epoll_pwait)

Sorry, but this is wrong. epoll_pwait manipulates the sigmask,
which is about the only thing that we can't let the SPU fiddle
with, so it should be COMPAT_SYS().

I just noticed the move_pages syscall that was added recently,
and that one should indeed be callable from an SPU.

This reminds me that I need to update the comment about what
calls are allowed from the SPU and which ones are not, since
we can now also allow optional ones like the mq_open mentioned
in the comment.

	Arnd <><

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-02-21  9:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-21  4:36 [POWERPC] wire up sys_epoll_pwait Stephen Rothwell
2007-02-21  9:36 ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox