* [PATCH 03/19] bootwrapper: Add ft_root_node().
@ 2007-03-12 20:41 Scott Wood
2007-03-12 22:29 ` Mark A. Greer
0 siblings, 1 reply; 3+ messages in thread
From: Scott Wood @ 2007-03-12 20:41 UTC (permalink / raw)
To: paulus; +Cc: linuxppc-dev
Clean up some of the open-coded data structure references by providing a
function to return a pointer to the tree's root node. This is only used
in high-level functions trying to access the root of the tree, not in
low-level code that is actually manipulating the data structure.
Signed-off-by: Scott Wood <scottwood@freescale•com>
---
arch/powerpc/boot/flatdevtree.c | 13 +++++++++----
1 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/boot/flatdevtree.c b/arch/powerpc/boot/flatdevtree.c
index c76c194..02823a8 100644
--- a/arch/powerpc/boot/flatdevtree.c
+++ b/arch/powerpc/boot/flatdevtree.c
@@ -29,6 +29,11 @@
#define _ALIGN(x, al) (((x) + (al) - 1) & ~((al) - 1))
+static char *ft_root_node(struct ft_cxt *cxt)
+{
+ return cxt->rgn[FT_STRUCT].start;
+}
+
/* Routines for keeping node ptrs returned by ft_find_device current */
/* First entry not used b/c it would return 0 and be taken as NULL/error */
static void *ft_node_add(struct ft_cxt *cxt, char *node)
@@ -590,7 +595,7 @@ int ft_add_rsvmap(struct ft_cxt *cxt, u64 physaddr, u64 size)
void ft_begin_tree(struct ft_cxt *cxt)
{
- cxt->p = cxt->rgn[FT_STRUCT].start;
+ cxt->p = ft_root_node(cxt);
}
void ft_end_tree(struct ft_cxt *cxt)
@@ -636,7 +641,7 @@ void *ft_find_device(struct ft_cxt *cxt, const char *srch_path)
/* require absolute path */
if (srch_path[0] != '/')
return NULL;
- node = ft_find_descendent(cxt, cxt->rgn[FT_STRUCT].start, srch_path);
+ node = ft_find_descendent(cxt, ft_root_node(cxt), srch_path);
return ft_node_add(cxt, node);
}
@@ -717,7 +722,7 @@ void *ft_get_parent(struct ft_cxt *cxt, const void *phandle)
return cxt->genealogy[d > 0 ? d - 1 : 0];
/* have to do it the hard way... */
- p = cxt->rgn[FT_STRUCT].start;
+ p = ft_root_node(cxt);
d = 0;
while ((p = ft_next(cxt, p, &atom)) != NULL) {
switch (atom.tag) {
@@ -855,7 +860,7 @@ void *ft_create_node(struct ft_cxt *cxt, const void *parent, const char *path)
char *p, *next;
int depth = 0;
- p = cxt->rgn[FT_STRUCT].start;
+ p = ft_root_node(cxt);
while ((next = ft_next(cxt, p, &atom)) != NULL) {
switch (atom.tag) {
case OF_DT_BEGIN_NODE:
--
1.5.0.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 03/19] bootwrapper: Add ft_root_node().
2007-03-12 20:41 [PATCH 03/19] bootwrapper: Add ft_root_node() Scott Wood
@ 2007-03-12 22:29 ` Mark A. Greer
2007-03-13 1:38 ` David Gibson
0 siblings, 1 reply; 3+ messages in thread
From: Mark A. Greer @ 2007-03-12 22:29 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev, paulus
On Mon, Mar 12, 2007 at 02:41:42PM -0600, Scott Wood wrote:
> Clean up some of the open-coded data structure references by providing a
> function to return a pointer to the tree's root node. This is only used
> in high-level functions trying to access the root of the tree, not in
> low-level code that is actually manipulating the data structure.
>
> Signed-off-by: Scott Wood <scottwood@freescale•com>
Acked-by: Mark A. Greer <mgreer@mvista•com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 03/19] bootwrapper: Add ft_root_node().
2007-03-12 22:29 ` Mark A. Greer
@ 2007-03-13 1:38 ` David Gibson
0 siblings, 0 replies; 3+ messages in thread
From: David Gibson @ 2007-03-13 1:38 UTC (permalink / raw)
To: Mark A. Greer; +Cc: linuxppc-dev, paulus
On Mon, Mar 12, 2007 at 03:29:29PM -0700, Mark A. Greer wrote:
> On Mon, Mar 12, 2007 at 02:41:42PM -0600, Scott Wood wrote:
> > Clean up some of the open-coded data structure references by providing a
> > function to return a pointer to the tree's root node. This is only used
> > in high-level functions trying to access the root of the tree, not in
> > low-level code that is actually manipulating the data structure.
> >
> > Signed-off-by: Scott Wood <scottwood@freescale•com>
>
> Acked-by: Mark A. Greer <mgreer@mvista•com>
Acked-by: David Gibson <david@gibson•dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-03-13 1:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-12 20:41 [PATCH 03/19] bootwrapper: Add ft_root_node() Scott Wood
2007-03-12 22:29 ` Mark A. Greer
2007-03-13 1:38 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox