public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: "Dale Farnsworth" <dale@farnsworth•org>
To: grant.likely@secretlab•ca, Linuxppc-embedded@ozlabs•org
Subject: Re: [PATCH 1/5] [PPC] Rework Kconfig dependancies for Xilinx Virtex ppc405 platform
Date: 15 Apr 2007 03:48:19 -0700	[thread overview]
Message-ID: <20070415104819.6709.qmail@farnsworth.org> (raw)
In-Reply-To: <11766220692537-git-send-email-grant.likely@secretlab.ca>

In article <11766220692537-git-send-email-grant.likely@secretlab•ca> you write:
> Reverse dependency order for Xilinx Virtex parts.  For these parts, It
> makes more sense for boards/chips to specify which features they
> provide instead of the features listing the parts they are implemented
> in.  I think it also makes adding new board ports simpler.
> 
> Signed-off-by: Grant Likely <grant.likely@secretlab•ca>
> ---
>  arch/ppc/platforms/4xx/Kconfig |   13 +++++++------
>  1 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/ppc/platforms/4xx/Kconfig b/arch/ppc/platforms/4xx/Kconfig
> index 705ae56..f74e25b 100644
> --- a/arch/ppc/platforms/4xx/Kconfig
> +++ b/arch/ppc/platforms/4xx/Kconfig
> @@ -54,11 +54,13 @@ config WALNUT
>  
>  config XILINX_ML300
>  	bool "Xilinx-ML300"
> +	select XILINX_VIRTEX_II_PRO
>  	help
>  	  This option enables support for the Xilinx ML300 evaluation board.
>  
>  config XILINX_ML403
>  	bool "Xilinx-ML403"
> +	select XILINX_VIRTEX_4_FX
>  	help
>  	  This option enables support for the Xilinx ML403 evaluation board.
>  endchoice
> @@ -215,18 +217,17 @@ config 405GPR
>  
>  config XILINX_VIRTEX_II_PRO
>  	bool
> -	depends on XILINX_ML300
> -	default y
> +	select XILINX_VIRTEX
> +	default n

Since these variables are not user selectable, it's better to
remove the "default n", so they don't show up when not selected.

>  config XILINX_VIRTEX_4_FX
>  	bool
> -	depends on XILINX_ML403
> -	default y
> +	select XILINX_VIRTEX
> +	default n
>  
>  config XILINX_VIRTEX
>  	bool
> -	depends on XILINX_VIRTEX_II_PRO || XILINX_VIRTEX_4_FX
> -	default y
> +	default n
>  
>  config STB03xxx
>  	bool
> -- 
> 1.5.1

-Dale

  parent reply	other threads:[~2007-04-15 10:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-15  7:27 Patchset to establish sanity in Xilinx Virtex support Grant Likely
2007-04-15  7:27 ` [PATCH 1/5] [PPC] Rework Kconfig dependancies for Xilinx Virtex ppc405 platform Grant Likely
2007-04-15  7:27   ` [PATCH 2/5] [PPC] Merge common virtex header files Grant Likely
2007-04-15  7:27     ` [PATCH 3/5] [PPC] New registration for common Xilinx Virtex ppc405 platform devices Grant Likely
2007-04-15  7:27       ` [PATCH 4/5] [PPC] Stop using ppc_sys for Xilinx Virtex boards Grant Likely
2007-04-15  7:27         ` [PATCH 5/5] [PPC] Add uartlite boot console driver for the zImage wrapper Grant Likely
2007-04-25 12:13           ` Peter Korsgaard
2007-04-25 12:12         ` [PATCH 4/5] [PPC] Stop using ppc_sys for Xilinx Virtex boards Peter Korsgaard
2007-04-25 12:11       ` [PATCH 3/5] [PPC] New registration for common Xilinx Virtex ppc405 platform devices Peter Korsgaard
2007-04-27 18:50         ` Grant Likely
2007-04-25 12:07     ` [PATCH 2/5] [PPC] Merge common virtex header files Peter Korsgaard
2007-04-27 18:49       ` Grant Likely
2007-04-30  4:26         ` Peter Korsgaard
2007-04-30  4:41           ` Grant Likely
2007-05-01  4:35             ` David H. Lynch Jr.
2007-05-01  7:16               ` Grant Likely
2007-05-01  4:28           ` David H. Lynch Jr.
2007-05-01  6:54             ` Grant Likely
2007-04-15 10:48   ` Dale Farnsworth [this message]
2007-04-15 14:20     ` [PATCH 1/5] [PPC] Rework Kconfig dependancies for Xilinx Virtex ppc405 platform Grant Likely
2007-04-25 12:03   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070415104819.6709.qmail@farnsworth.org \
    --to=dale@farnsworth$(echo .)org \
    --cc=Linuxppc-embedded@ozlabs$(echo .)org \
    --cc=grant.likely@secretlab$(echo .)ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox