From: "David H. Lynch Jr." <dhlii@dlasys•net>
To: linuxppc-embedded <linuxppc-embedded@ozlabs•org>
Subject: Re: [PATCH 2/5] [PPC] Merge common virtex header files
Date: Tue, 01 May 2007 00:28:07 -0400 [thread overview]
Message-ID: <4636C1D7.9090309@dlasys.net> (raw)
In-Reply-To: <87slai5vz3.fsf@sleipner.barco.com>
Peter Korsgaard wrote:
> GL> Alternate suggestion: Can we change virtex support to use the
> GL> structure defined in ppcboot.h instead? (I've actually got that
> GL> change in my tree and was planning on posting it for review today
> GL> or tomorrow). bd_t is a stinking ugly mess, but things would be
> GL> better if we standardize all virtex platforms on the stinking ugly
> GL> mess shared by almost all the other ppc embedded board ports.
>
> That's where the ugly mess pops up - RedBoot uses another
> (incompatible) bd_t definition than U-boot, E.G:
>
> typedef struct bd_info {
> unsigned int bi_tag; /* Should be 0x42444944 "BDID" */
>
snip
>
> int bi_flashwidth; /* Width (8,16,32,64) */
> unsigned char *bi_cmdline; /* Pointer to command line */
> } bd_t;
>
> I should probably migrate to U-boot anyway, but still ..
>
Can we please not standardize on some specific implimentation of
bd_info ?
We have our own bootloader - actually a monitor. It does alot of
things besides boot Linux.
and it does so in less than 16K.
our bd_info struct is used to pass info to OS's besides Linux.
It does not have all the crap the u-boot bd_info has in it that has
no meaning for us.
But it does have some things that are very specific to our
hardware/firmware.
It took a quick look at Grant's virtex patches, and will try to test
them with our cards,
as soon as I can, but the inclusion of a specific virtex bd_info
leapt out instantly as something
I would have to patch.
Besides, I am not current on the powerpc tree but isn't this kind of
thing what device trees are
supposed to be about and don't we have to do that anyway to migrate
to the powerpc tree ?
--
Dave Lynch DLA Systems
Software Development: Embedded Linux
717.627.3770 dhlii@dlasys•net http://www.dlasys.net
fax: 1.253.369.9244 Cell: 1.717.587.7774
Over 25 years' experience in platforms, languages, and technologies too numerous to list.
"Any intelligent fool can make things bigger and more complex... It takes a touch of genius - and a lot of courage to move in the opposite direction."
Albert Einstein
next prev parent reply other threads:[~2007-05-01 4:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-15 7:27 Patchset to establish sanity in Xilinx Virtex support Grant Likely
2007-04-15 7:27 ` [PATCH 1/5] [PPC] Rework Kconfig dependancies for Xilinx Virtex ppc405 platform Grant Likely
2007-04-15 7:27 ` [PATCH 2/5] [PPC] Merge common virtex header files Grant Likely
2007-04-15 7:27 ` [PATCH 3/5] [PPC] New registration for common Xilinx Virtex ppc405 platform devices Grant Likely
2007-04-15 7:27 ` [PATCH 4/5] [PPC] Stop using ppc_sys for Xilinx Virtex boards Grant Likely
2007-04-15 7:27 ` [PATCH 5/5] [PPC] Add uartlite boot console driver for the zImage wrapper Grant Likely
2007-04-25 12:13 ` Peter Korsgaard
2007-04-25 12:12 ` [PATCH 4/5] [PPC] Stop using ppc_sys for Xilinx Virtex boards Peter Korsgaard
2007-04-25 12:11 ` [PATCH 3/5] [PPC] New registration for common Xilinx Virtex ppc405 platform devices Peter Korsgaard
2007-04-27 18:50 ` Grant Likely
2007-04-25 12:07 ` [PATCH 2/5] [PPC] Merge common virtex header files Peter Korsgaard
2007-04-27 18:49 ` Grant Likely
2007-04-30 4:26 ` Peter Korsgaard
2007-04-30 4:41 ` Grant Likely
2007-05-01 4:35 ` David H. Lynch Jr.
2007-05-01 7:16 ` Grant Likely
2007-05-01 4:28 ` David H. Lynch Jr. [this message]
2007-05-01 6:54 ` Grant Likely
2007-04-15 10:48 ` [PATCH 1/5] [PPC] Rework Kconfig dependancies for Xilinx Virtex ppc405 platform Dale Farnsworth
2007-04-15 14:20 ` Grant Likely
2007-04-25 12:03 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4636C1D7.9090309@dlasys.net \
--to=dhlii@dlasys$(echo .)net \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox