From: Andrew Morton <akpm@linux-foundation•org>
To: Vitaly Bordug <vitb@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, linux-pcmcia@lists•infradead.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support
Date: Mon, 14 May 2007 14:21:25 -0700 [thread overview]
Message-ID: <20070514142125.851f3d10.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070508223123.3633.72309.stgit@localhost.localdomain>
On Wed, 09 May 2007 02:31:25 +0400
Vitaly Bordug <vitb@kernel•crashing.org> wrote:
> +/*
> + * Some internal interrupt registers use an 8-bit mask for the interrupt
> + * level instead of a number.
> + */
> +static inline uint mk_int_int_mask(uint mask) {
> + return (1 << (7 - (mask/2)));
> +}
grumble. "uint" isn't a favoured "type". Please prefer to
use "unsigned int" if that's what is meant. Or maybe u32,
if that's more appropriate - and it probably is, as we're
dealing with device registers here.
next prev parent reply other threads:[~2007-05-14 21:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 22:31 [PATCH 0/3] 8xx PCMCIA stuff && cleanup: take 4 Vitaly Bordug
2007-05-08 22:31 ` [PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support Vitaly Bordug
2007-05-14 21:21 ` Andrew Morton [this message]
2007-05-08 22:31 ` [PATCH 2/3] [POWERPC] 8xx: fix whitespace and indentation Vitaly Bordug
2007-05-08 22:31 ` [PATCH 3/3] [POWERPC] dts: kill hardcoded phandles Vitaly Bordug
-- strict thread matches above, loose matches on Subject: below --
2007-05-08 9:50 [PATCH 0/3] 8xx PCMCIA stuff && cleanup: take 3 Vitaly Bordug
2007-05-08 9:50 ` [PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support Vitaly Bordug
2007-05-08 14:04 ` Kumar Gala
2007-05-08 17:31 ` Vitaly Bordug
2007-05-08 21:19 ` Vitaly Bordug
[not found] <20070508053049.18428.50622.stgit@localhost.localdomain>
2007-05-08 5:48 ` Vitaly Bordug
2007-05-08 6:02 ` Olof Johansson
2007-05-08 0:36 Vitaly Bordug
2007-05-08 5:58 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070514142125.851f3d10.akpm@linux-foundation.org \
--to=akpm@linux-foundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pcmcia@lists$(echo .)infradead.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=vitb@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox