From: olof@lixom•net (Olof Johansson)
To: Milton Miller <miltonm@bga•com>
Cc: ppcdev <linuxppc-dev@ozlabs•org>
Subject: Re: [PATCH] pcmcia: CompactFlash driver for PA Semi Electra boards
Date: Thu, 5 Jul 2007 09:36:56 -0500 [thread overview]
Message-ID: <20070705143656.GA14343@lixom.net> (raw)
In-Reply-To: <024cbfe00dde1c97bb249b925f55ebee@bga.com>
On Wed, Jun 27, 2007 at 06:20:27AM -0500, Milton Miller wrote:
> get_property is now a #define for of_get_property. I think the use of
> get_property is being deprecated.
Yeah, it's a pita. I've moved these over now.
> If of_get_property fails to find the property, then you will
> dereference a NULL pointer in a probe function and will leave the
> bus_type locked.
Fixed.
> >+ /* XXX No way to undo the io reservation at this time */
>
> What io reservation is this comment referring to?
ioremap_explicit. I've updated the comment.
> Where is the request_irq undone?
Fixed.
> >+static int __devexit electra_cf_remove(struct of_device *ofdev)
> >+{
> >+ struct device *device = &ofdev->dev;
> >+ struct electra_cf_socket *cf;
> >+
> >+ cf = dev_get_drvdata(device);
> >+
> >+ cf->active = 0;
> >+ pcmcia_unregister_socket(&cf->socket);
> >+ free_irq(cf->irq, cf);
> >+ del_timer_sync(&cf->timer);
> >+
> >+ iounmap(cf->mem_base);
> >+ iounmap(cf->gpio_base);
> >+ release_mem_region(cf->mem_phys, cf->mem_size);
> >+ release_region(cf->io_base, cf->io_size);
> >+
> >
>
> irq_request?
Huh?
-Olof
prev parent reply other threads:[~2007-07-05 14:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 1:03 [PATCH] pcmcia: CompactFlash driver for PA Semi Electra boards Olof Johansson
2007-06-25 5:56 ` Christoph Hellwig
2007-06-25 15:50 ` Olof Johansson
2007-06-25 17:12 ` [PATCH v2] " Olof Johansson
2007-06-25 19:39 ` Christoph Hellwig
2007-06-25 20:43 ` Olof Johansson
2007-07-05 14:49 ` [PATCH v3] " Olof Johansson
2007-07-20 23:48 ` Andrew Morton
2007-07-21 20:18 ` Olof Johansson
2007-08-31 2:43 ` [PATCH -mm] pcmcia: Updates to electra_cf driver Olof Johansson
2007-06-27 11:20 ` [PATCH v2] pcmcia: CompactFlash driver for PA Semi Electra boards Milton Miller
2007-07-05 14:37 ` Olof Johansson
2007-06-27 11:20 ` [PATCH] " Milton Miller
2007-07-05 14:36 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070705143656.GA14343@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=miltonm@bga$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox