From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc-dev@ozlabs•org, rrnelson@linux•vnet.ibm.com
Cc: oprofile <oprofile-list@lists•sf.net>,
Andrew Morton <akpm@linuxfoundation•org>,
Philippe Elie <phil.el@wanadoo•fr>
Subject: Re: [PATCH 2/2] Add support to OProfile for profiling Cell BE SPUs
Date: Fri, 13 Jul 2007 12:02:19 +0200 [thread overview]
Message-ID: <200707131202.19635.arnd@arndb.de> (raw)
In-Reply-To: <1184284059.16584.7.camel@bnelson60.rchland.ibm.com>
On Friday 13 July 2007, Bob Nelson wrote:
> We would like this patch included in -mm and 2.6.23.
>=20
> Subject: Add support to OProfile for profiling Cell BE SPUs
>=20
> From: Maynard Johnson <mpjohn@us•ibm.com>
> Bob Nelson <rrnelson@us•ibm.com>
>=20
The patch itself looks ok, but unfortunately, you have a few
formal mistakes in the submission. Most importantly, the long
lines got wrapped by your mail client, so it won't apply.
About the start of the mail, please put the 'We would like to...'
part and everything else that is not supposed to show up in
the changelog _below_ the introduction, separated from the
changelog with a single line containing the string '---'.
The Subject: line should not be in the mail body, it's only
used if you want to use the 'quilt mail' tool, which will
move it to the real subject of the mail.
The From: line can only have one name in it. If you want to
give credit to multiple people, that should be in the
changelog text.
Please resend.
Arnd <><
> This patch updates the existing arch/powerpc/oprofile/op_model_cell.c
> to add in the SPU profiling capabilities. =A0In addition, a 'cell'
> subdirectory
> was added to arch/powerpc/oprofile to hold Cell-specific SPU profiling
> code.
> Also incorporated several fixes from other patches. =A0Check pointer
> returned from kzalloc. =A0Eliminated unnecessary cast. =A0Better error
> handling and cleanup in the related area. =A064-bit unsigned long
> parameter
> was being demoted to 32-bit unsigned int and eventually promoted back to
> unsigned long.
>=20
> Signed-off-by: Carl Love <carll@us•ibm.com>
> Signed-off-by: Maynard Johnson <mpjohn@us•ibm.com>
> Signed-off-by: Bob Nelson <rrnelson@us•ibm.com>
> Acked-by: Arnd Bergmann <arnd.bergmann@de•ibm.com>
> Acked-by: Paul Mackerras <paulus@samba•org>
prev parent reply other threads:[~2007-07-13 10:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-12 23:47 [PATCH 2/2] Add support to OProfile for profiling Cell BE SPUs Bob Nelson
2007-07-13 10:02 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707131202.19635.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=akpm@linuxfoundation$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=oprofile-list@lists$(echo .)sf.net \
--cc=phil.el@wanadoo$(echo .)fr \
--cc=rrnelson@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox